<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#CCCCCC" text="#000000">
On 4/10/12 2:47 PM, Dmitry Samersoff wrote:
<blockquote cite="mid:4F84AA69.9080103@oracle.com" type="cite">Dan,
<br>
<br>
Looks good for me.
<br>
<br>
<br>
1.
<br>
<br>
239 # If Full Debug Symbols is enabled, then we want the same
debug and
<br>
240 # optimization flags as used by FASTDEBUG. We also want all
the
<br>
241 # debug info in one place (-xs).
<br>
<br>
Sorry! I'm later at the party. What is the reason of enforcing
certain optimization level with FDS?
<br>
<br>
<br>
2.
<br>
192 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
<br>
193 ifeq ($(ZIP_DEBUGINFO_FILES),1)
<br>
194 (set -e ; \
<br>
195 $(CD) $(OBJDIR) ; \
<br>
196 $(ZIPEXE) -q $(PROGRAM).diz $(PROGRAM).map
$(PROGRAM).pdb ; \
<br>
197 $(RM) $(PROGRAM).map $(PROGRAM).pdb ; \
<br>
198 )
<br>
199 endif
<br>
200 endif
<br>
<br>
<br>
No fallback on zip error here. No ideas what we should do if zip
fails, so it just a FYI.
<br>
</blockquote>
My understanding is the 'set -e' (line 194) should cause the build
to fail.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<blockquote cite="mid:4F84AA69.9080103@oracle.com" type="cite">
<br>
-Dmitry
<br>
<br>
<br>
On 2012-04-11 01:17, Daniel D. Daugherty wrote:
<br>
<blockquote type="cite">Thanks Serguei!
<br>
<br>
Dan
<br>
<br>
<br>
On 4/10/12 2:51 PM, <a class="moz-txt-link-abbreviated" href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:
<br>
<blockquote type="cite">Dan,
<br>
<br>
It is good.
<br>
<br>
Thanks,
<br>
Serguei
<br>
<br>
On 4/9/12 1:51 PM, Daniel D. Daugherty wrote:
<br>
<blockquote type="cite">Greetings,
<br>
<br>
Coming soon to a JDK repo near you! Full Debug Symbols!
<br>
<br>
OK, to just a subset of libraries and programs... on Linux
and
<br>
Solaris...
<br>
If you're a Windows fan, the JDK repo has had Full Debug
Symbols support
<br>
since way back in JDK1.4.1... Now we're trying get Linux and
Solaris
<br>
caught up...
<br>
<br>
Runtime Team, we don't have much in the JDK repo, but I
tried to cover
<br>
our few libraries and programs. Let me know if I missed
anything...
<br>
<br>
Serviceability Team, all of your demos, libraries and
programs are
<br>
covered... for some reason, updating those seemed like
reliving old
<br>
times and I didn't think you'd mind... :-)
<br>
<br>
Here is the webrev URL:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dcubed/fds_revamp/7071907-webrev/0-jdk8-jdk/">http://cr.openjdk.java.net/~dcubed/fds_revamp/7071907-webrev/0-jdk8-jdk/</a>
<br>
<br>
Thanks, in advance, for any review comments.
<br>
<br>
Dan
<br>
<br>
P.S.
<br>
For those of you that are keeping track of all the FDS
<br>
changesets, not everything has hit the various master
<br>
repos yet. As a reminder, FDS has to hit the closed
<br>
install repo first. The open root and jdk repos along
<br>
with the closed deploy repo are in the second wave. And
<br>
the hotspot repo, being more Mercurial than his fellow
<br>
ghosts, will make his appearance in his own good time
<br>
(and via a different set of repos)...
<br>
<br>
Apologies to Dickens, of course... :-)
<br>
<br>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
<br>
</blockquote>
<br>
</body>
</html>