<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#CCCCCC" text="#000000">
I do not see any issues with that webrev.<br>
Looks good.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
On 5/23/12 12:59 PM, Daniel D. Daugherty wrote:
<blockquote cite="mid:4FBD41A0.4080408@oracle.com" type="cite">Greetings,
<br>
<br>
This is a hotspot code review request for the second of a pair of
<br>
Full Debug Symbols gobjcopy work arounds on Solaris. The first
<br>
hotspot FDS gobjcopy work around was reviewed using bug 7165060
<br>
and that fixed the dtrace test failures.
<br>
<br>
The gobjcopy utility also crashes due to empty sections with the
<br>
SHF_ALLOC flagset on Solaris X64 objects. This causes build
<br>
failures.
<br>
<br>
The first new temporary work around tool is add_gnu_debuglink
<br>
and it was added by 7165060.The second new temporary work around
<br>
tool is:
<br>
<br>
fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty
<br>
sections in ELF objects.
<br>
<br>
These temporary work arounds are only needed until the proper
<br>
Solaris 10 Update 6 patches are made available. The two patches
<br>
are independent of one another which is why there are two
<br>
separate temporary work arounds. However, we're putting the
<br>
temporary work arounds in place because the 7u6/HSX-23.2 project
<br>
window is closing fast.
<br>
<br>
Here is the webrev URL for the HSX-24 version:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/">http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/</a>
<br>
<br>
This fix will also be backported to 7u6/HSX-23.2 and I expect the
<br>
changes to virtually identical.
<br>
<br>
Thanks, in advance, for any reviews!
<br>
<br>
Dan
<br>
<br>
<br>
</blockquote>
<br>
</body>
</html>