<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div><div><font class="Apple-style-span" face="monospace">Are these ok?</font></div><div><font class="Apple-style-span" face="monospace"><br></font></div><div><font class="Apple-style-span" face="monospace"><div>./share/classes/sun/nio/ch/DatagramChannelImpl.java:@GenerateNativeHeader</div></font></div><div><span class="Apple-style-span" style="font-family: monospace; ">./share/classes/sun/nio/ch/IOStatus.java:@GenerateNativeHeader</span></div><div><font class="Apple-style-span" face="monospace"></font><span class="Apple-style-span" style="font-family: monospace; ">./share/classes/sun/nio/ch/sctp/SctpStdSocketOption.java:@GenerateNativeHeader</span></div><div><span class="Apple-style-span" style="font-family: monospace; ">./solaris/classes/sun/nio/ch/sctp/AssociationChange.java:@GenerateNativeHeader</span></div><div><font class="Apple-style-span" face="monospace"></font><span class="Apple-style-span" style="font-family: monospace; ">./solaris/classes/sun/nio/ch/sctp/PeerAddrChange.java:@GenerateNativeHeader</span></div><div><font class="Apple-style-span" face="monospace"></font><span class="Apple-style-span" style="font-family: monospace; ">./solaris/classes/sun/nio/ch/sctp/ResultContainer.java:@GenerateNativeHeader</span></div><div><span class="Apple-style-span" style="font-family: monospace; ">./windows/classes/sun/nio/ch/PollArrayWrapper.java:@GenerateNativeHeader</span><font class="Apple-style-span" face="monospace"><div><br></div></font><div><font class="Apple-style-span" face="monospace"><br></font></div><div><font class="Apple-style-span" face="monospace">Otherwise, the change looks ok to me, although I was puzzled by the "| $(BUILD_JDK)" in</font></div><div><font class="Apple-style-span" face="monospace"><pre><span class="new"> 314 $(JDK_OUTPUTDIR)/classes/_the.jdk.base.headers: $(JDK_BASE_HEADER_JAVA_FILES) | $(BUILD_JDK)</span></pre><div>Never seen a | character in the dependencies before, is that a valid syntax?</div><div><br></div></font></div><div><font class="Apple-style-span" face="monospace">-kto</font></div><div><font class="Apple-style-span" face="monospace"><br></font><div><div>On Jun 4, 2012, at 7:15 AM, Erik Joelsson wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>I have created a (hopefully temporary) hack to run javah manually for these 5 classes. This webrev is just against the build-infra repo. Unless anybody objects to this temporary solution, I will publish a new full webrev against the jdk8/build forest tomorrow.<br><br><a href="http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/">http://cr.openjdk.java.net/~erikj/build-infra-m1.1/jdk-base-headers/</a> <<a href="http://cr.openjdk.java.net/%7Eerikj/build-infra-m1.1/jdk-base-headers/">http://cr.openjdk.java.net/%7Eerikj/build-infra-m1.1/jdk-base-headers/</a>><br><br>/Erik<br><br>On 2012-05-23 19:05, Alan Bateman wrote:<br><blockquote type="cite">On 23/05/2012 17:50, Kelly O'Hair wrote:<br></blockquote><blockquote type="cite"><blockquote type="cite">Has anyone tried creating an unused native method declaration in the class to trigger the native header<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">generation? public native void GenerateNativeHeader(); ??? Is that too ugly?<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">-kto<br></blockquote></blockquote><blockquote type="cite">As Jon put it, for the classes in the base module, "we are delicate bootstrapping ground" so if you add something like "private static native void dummy()" rather than the annotation to the classes in the base module then it could be a solution for the short term. This means the following sources in the webrev:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">src/share/classes/java/lang/Integer.java<br></blockquote><blockquote type="cite">src/share/classes/java/lang/Long.java<br></blockquote><blockquote type="cite">src/share/classes/java/net/SocketOptions.java<br></blockquote><blockquote type="cite">src/windows/classes/sun/nio/ch/PollArrayWrapper.java<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Also it would be good to remove it from src/share/classes/sun/nio/ch/IOStatus.java too (it got the annotation in the first round).<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">-Alan.<br></blockquote><blockquote type="cite"><br></blockquote></div></blockquote></div><br></div></div></body></html>