<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Can I have a Review for this change, please?<div><br></div><div>The very simple fix is here: <a href="http://cr.openjdk.java.net/~sla/7178667/webrev.02/">http://cr.openjdk.java.net/~sla/7178667/webrev.02/</a></div><div><br></div><div>Thanks,</div><div>/Staffan<br><div><br><div><div>On 25 jun 2012, at 10:36, Staffan Larsen wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">So, it sounds like when you rebuilt, everything was built into jre/lib/i386 and jre/lib/amd64, but never combined (or, in this case, just copied) into jre/lib, and therefore not found.<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Yes. Or rather, only the client jvm was combined, but the client jvm isn't copied into the j2sdk-image on mac, so nothing was copied.<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Which begs the question: if we only build 64-bit on OSX then how/why is client being built in the first place?<br></blockquote><br>I should have said: "only the client jvm was _attempted_ to be combined". In fact, the client does not exist, but the universalize makefiles are written to handle client if it did exist. <br><br>So what happened was: <br> - the product jvm was built<br> - it was copied to the import jdk (into jre/lib/amd64/server/) by the generic_export target<br> - the universalize makefile tried to take the client jvm and universalize it into jre/lib/client/ (notice that there is no amd64 directory level on mac)<br> - the universalize makefile removes all {amd64,i386} directories<br><br>What should have happened:<br> - the product jvm was built<br> - it was copied to the import jdk (into jre/lib/amd64/server/) by the generic_export target<br> - the universalize makefile makes a universal binary of any existing jvms (client or server)<br> - the universalize makefile copies these jvms into jre/lib/{server,client}<br> - the universalize makefile removes all {amd64,i386} directories<br><br>But because the targets weren't .PHONY, the third step above failed.<br><br>I hope that explains the problem in more detail. Who wants to be put down as reviewer?<br><br>Thanks,<br>/Staffan<br><br></div></blockquote></div><br></div></div></body></html>