<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Menlo;
panose-1:2 11 6 9 3 8 4 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-GB" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">H David,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<pre><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;mso-fareast-language:EN-US">The key difference is that we wouldn’t nee to keep updating the full version number/checksum. We could ofcourse use the <a href="https://github.com/oracle-actions/setup-java">oracle-actions/setup-java</a> and do something like this:<br><br></span><span style="font-family:Menlo;color:#24292F"> - name: 'Set up latest Oracle JDK 18'<o:p></o:p></span></pre>
<p class="MsoNormal"><span style="font-family:Menlo;color:#24292F"> uses: oracle-actions/setup-java@v1<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Menlo;color:#24292F"> with:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Menlo;color:#24292F"> website: oracle.com<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Menlo;color:#24292F"> release: 18<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">I’m more than happy to leave the codebase as it is but I don’t like the way that we have to keep updating the version number/checksum.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">George<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">David Holmes <david.holmes@oracle.com><br>
<b>Date: </b>Tuesday, 12 July 2022 at 02:24<br>
<b>To: </b>George Adams <George.Adams@microsoft.com>, build-dev@openjdk.org <build-dev@openjdk.org><br>
<b>Subject: </b>[EXTERNAL] Re: GitHub workflows using setup-java action instead of hardcoded URLs<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt">[You don't often get email from david.holmes@oracle.com. Learn why this is important at
<a href="https://aka.ms/LearnAboutSenderIdentification">https://aka.ms/LearnAboutSenderIdentification</a> ]<br>
<br>
Hi George,<br>
<br>
On 12/07/2022 6:30 am, George Adams wrote:<br>
> Hi all,<br>
><br>
> I was speaking with Christoph Clanger today about the GitHub actions<br>
> rewrite <<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.org%2Fbrowse%2FJDK-8287906&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=hEzzv1iXX4TmSoWA%2BqoNKleGGPxr4Z9izrsxApfJfVs%3D&reserved=0">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.org%2Fbrowse%2FJDK-8287906&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=hEzzv1iXX4TmSoWA%2BqoNKleGGPxr4Z9izrsxApfJfVs%3D&reserved=0</a>>
which has already<br>
> made contributing so much simpler.<br>
><br>
> I wanted to see if there was an interest in switching to using the<br>
> actions/setup-java <<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Factions%2Fsetup-java&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Zsb%2BEAJz0K1GkNwSC%2Fmep4cbkQeH68PxPb6ULUQqSqA%3D&reserved=0">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Factions%2Fsetup-java&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Zsb%2BEAJz0K1GkNwSC%2Fmep4cbkQeH68PxPb6ULUQqSqA%3D&reserved=0</a>>
GitHub action<br>
> as a way of handling the Boot JDK installation rather than the current<br>
> hardcoded URLs defined here<br>
> <a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk%2Fblob%2Fmaster%2Fmake%2Fconf%2Fgithub-actions.conf%23L31-L41&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=bVhVDzv%2FJxXCeVgpDGVi8sdxOTQZvT6R4730ay%2BU%2Bk4%3D&reserved=0">
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk%2Fblob%2Fmaster%2Fmake%2Fconf%2Fgithub-actions.conf%23L31-L41&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=bVhVDzv%2FJxXCeVgpDGVi8sdxOTQZvT6R4730ay%2BU%2Bk4%3D&reserved=0</a><br>
> <<a href="https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk%2Fblob%2Fmaster%2Fmake%2Fconf%2Fgithub-actions.conf%23L31-L41&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=bVhVDzv%2FJxXCeVgpDGVi8sdxOTQZvT6R4730ay%2BU%2Bk4%3D&reserved=0">https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk%2Fblob%2Fmaster%2Fmake%2Fconf%2Fgithub-actions.conf%23L31-L41&data=05%7C01%7CGeorge.Adams%40microsoft.com%7Cda1703f1651e40f195b408da63a54a13%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637931858846280896%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=bVhVDzv%2FJxXCeVgpDGVi8sdxOTQZvT6R4730ay%2BU%2Bk4%3D&reserved=0</a>><br>
><br>
> If people think this is a good idea then I’ll submit a patch for review<br>
> this week.<br>
<br>
I don't really see any benefit to doing this, especially when the<br>
existing hardcoded downloads do not even appear to be available via<br>
setup-java. And even if they were we would just replace a fixed known<br>
URL with a fixed known (java-version, distribution) pair of arguments to<br>
setup-java. And setup-java seems to do far more than what we need for<br>
our GHA testing.<br>
<br>
Just my 2c.<br>
<br>
Cheers,<br>
David<br>
<br>
><br>
> Thanks<br>
><br>
> George<br>
><o:p></o:p></span></p>
</div>
</div>
</body>
</html>