<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>On 2022-09-18 12:15, Roma Marchenko wrote:<br>
</p>
<blockquote type="cite" cite="mid:DM8PR11MB57367657BB1BB2004C0D9755BF4A9@DM8PR11MB5736.namprd11.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}span.EmailStyle18
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}div.WordSection1
{page:WordSection1;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Hello,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal">There was <span lang="EN-US">P4 </span>JDK-8275008
<span lang="EN-US">
(<a href="https://bugs.openjdk.org/browse/JDK-8275008" moz-do-not-send="true" class="moz-txt-link-freetext">https://bugs.openjdk.org/browse/JDK-8275008</a>)</span>
about GKC 11 warning 'stringop-overflow' in gtest::Guarded
Memory.<o:p></o:p></p>
<p class="MsoNormal">It was fixed globally by disabling this
warning for all openjdk
<span lang="EN-US">g</span>test<span lang="EN-US">s</span>,
although in fact the only test required this fix. Moreover,
this wasn't a bug, because the test really does 'buffer
overflow' to check memory guards then.
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I realize that it's just a test, not a
product, but anyway '-Wstringop-overflow' is not '-Wundef',
and I don't think that disabling 'stringop-overflow' for all
the tests is a good idea. Again, as far as I see, there are no
other tests occurring this warning. Is it better to disable
the warning locally in the test <span lang="EN-US">
on upstream </span>and add a comment describing expected
behaviour regarding buffer overflow?</p>
</div>
</blockquote>
<p>Unfortunately, there is currently no really nice way to disable a
warning for a single test. In that case, you'd have to resort to
pragmas.</p>
<p>This is a known limitation in the build system that I hope to be
able to address in not a too far-off future.<br>
</p>
<p>/Magnus<br>
</p>
<blockquote type="cite" cite="mid:DM8PR11MB57367657BB1BB2004C0D9755BF4A9@DM8PR11MB5736.namprd11.prod.outlook.com">
<div class="WordSection1">
<p class="MsoNormal"><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span lang="EN-US">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Roman<o:p></o:p></span></p>
</div>
</blockquote>
</body>
</html>