<div dir="auto">I’m curious, why does the options function have to be exported? Who is consuming it?</div><div dir="auto"><br></div><div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed 15. Feb 2023 at 19:01, Justin King <<a href="mailto:jcking@openjdk.org">jcking@openjdk.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">Update build-related infrastructure to support building with ASan under Microsoft Visual C++.<br>
<br>
-------------<br>
<br>
Commit messages:<br>
 - Move comment to appropriate location<br>
 - Use elif instead of separate if<br>
 - Only pass -fsanitize=address to linker for Clang/GCC<br>
 - Update asan_default_options.c with MSVC-specific extensions<br>
 - Support using ASan with MSVC<br>
<br>
Changes: <a href="https://git.openjdk.org/jdk/pull/12580/files" rel="noreferrer" target="_blank">https://git.openjdk.org/jdk/pull/12580/files</a><br>
 Webrev: <a href="https://webrevs.openjdk.org/?repo=jdk&pr=12580&range=00" rel="noreferrer" target="_blank">https://webrevs.openjdk.org/?repo=jdk&pr=12580&range=00</a><br>
  Issue: <a href="https://bugs.openjdk.org/browse/JDK-8302599" rel="noreferrer" target="_blank">https://bugs.openjdk.org/browse/JDK-8302599</a><br>
  Stats: 25 lines in 2 files changed: 18 ins; 0 del; 7 mod<br>
  Patch: <a href="https://git.openjdk.org/jdk/pull/12580.diff" rel="noreferrer" target="_blank">https://git.openjdk.org/jdk/pull/12580.diff</a><br>
  Fetch: git fetch <a href="https://git.openjdk.org/jdk" rel="noreferrer" target="_blank">https://git.openjdk.org/jdk</a> pull/12580/head:pull/12580<br>
<br>
PR: <a href="https://git.openjdk.org/jdk/pull/12580" rel="noreferrer" target="_blank">https://git.openjdk.org/jdk/pull/12580</a><br>
</blockquote></div></div>