<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hello Matthias,</p>
<p>Double '$' in makefiles is used to escape '$' when called by the
$(eval $(call ...)) combination. Care needs to be taken to use
either double or single '$' to control when (in which make
evaluation phase) a variable or macro call is evaluated. In
practice this means that we mainly use double '$' inside macro
bodies. Sometimes either will work, but we have decided to stick
to double '$' inside macro bodies unless there is a reason not to,
for consistency.</p>
<p>The call to isTargetOs in this case is inside the macro body of
SetupRunJtregTest, so the use of double '$' is expected and
preferred.</p>
<p>/Erik<br>
</p>
<div class="moz-cite-prefix">On 3/15/23 04:27, Baesken, Matthias
wrote:<br>
</div>
<blockquote type="cite" cite="mid:AM9PR02MB67702F92B427F666A9E0AB8693BF9@AM9PR02MB6770.eurprd02.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}div.WordSection1
{page:WordSection1;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi, I noticed a double
usage of ‘$’ in<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="en-DE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="en-DE">jdk/make/RunTests.gmk <o:p></o:p></span></p>
<p class="MsoNormal"><span lang="en-DE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="en-DE">800 ifeq ($$(call
isTargetOs, windows), true)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="en-DE">801
$1_JTREG_BASIC_OPTIONS += -e:_NT_SYMBOL_PATH<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="en-DE"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Is there some good
reason for this, the other
</span><span lang="en-DE">call isTargetOs</span><span lang="EN-US"> - snippets in the Makefiles do not use $$
?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards, Matthias<o:p></o:p></span></p>
</div>
</blockquote>
</body>
</html>