<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hello Chen Liang,</p>
<p>The exploded image optimization step runs the newly built JDK (in
the exploded image) to generate data for itself. This means that
if you change something fundamental in the JDK core libraries or
the JVM, that may cause crashes in this build step. To diagnose
further, you can run/debug the exploded image directly.<br>
</p>
<p>/Erik<br>
</p>
<div class="moz-cite-prefix">On 8/31/23 19:54, - wrote:<br>
</div>
<blockquote type="cite" cite="mid:CABe8uE1obQbwDSVE2EJTfex+OGYjoW_90VdWtpu_RJm_Lk3Emw@mail.gmail.com">
<div dir="ltr">Hello,
<div>I am trying to create a patch [1] that optimizes forEach
for immutable factory collections (from List/Set.of) to see
how it compares with constant-folded random access. However,
this patch somehow tampers with exploded image optimization
and modules during build, and I cannot build this patch on my
windows 11 device.</div>
<div><br>
</div>
<div>I have tried using both Oracle JDK 20 build 20+36-2344 (in
JAVA_HOME) and the JDK 21 build 35 as boot JDK. JDK 20 fails
with an IAE with message "Bad package name" (seems to be from
modules.cpp) and JDK 21 fails with an NPE
'java.lang.NullPointerException: Cannot invoke "<a href="http://java.lang.module.ResolvedModule.name" moz-do-not-send="true">java.lang.module.ResolvedModule.name</a>()"
because "resolvedModules[index]" is null', both happening
after reconfiguring and cleaning. These are my command-line:</div>
<div><br>
</div>
<div>bash configure --with-boot-jdk=/cygdrive/c/java/boot/jdk-21
--enable-hsdis-bundling --with-hsdis=capstone
--with-capstone=/cygdrive/c/java/capstone-4.0.2-win64
--with-jmh=build/jmh/jars --with-conf-name=windows-x64
--enable-jtreg-failure-handler<br>
</div>
<div><br>
</div>
<div>Does anybody have any clue on why my patch fails the build?
And how can I resolve this problem?</div>
<div><br>
</div>
<div>Chen Liang<br>
<div><br>
</div>
<div>[1] <a href="https://github.com/liachmodded/jdk/pull/new/feature/imm-coll-stream" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/liachmodded/jdk/pull/new/feature/imm-coll-stream</a><br>
</div>
</div>
</div>
</blockquote>
</body>
</html>