<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
Hi Magnus,<br>
<br>
<br>
<div class="moz-cite-prefix">On 05/12/2023 13:58, Magnus Ihse Bursie
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:4b62dd64-a3c0-4656-a0c1-83b9038c08e3@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div>
<div class="edit-comment-hide">
<div
class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block">
</div>
</div>
</div>
<p>So this is really a "--with-jdk-rc-vendor-name", since it will
use that value instead of --with-jdk-vendor-name for the RC
fields in Windows binaries?</p>
</blockquote>
I don't have a strong opinion about the name, only the target RC
field in question is called "CompanyName", and this new option would
only be used to set this property, so referencing to this instead of
the term "vendor" made maybe more sense to me.<br>
<br>
<blockquote type="cite"
cite="mid:4b62dd64-a3c0-4656-a0c1-83b9038c08e3@oracle.com">
<p>Would --with-jdk-vendor-name be used for anything at all on
Windows in that case?</p>
</blockquote>
<br>
I can't find any references to an existing "--with-jdk-vendor-name"
so I assume than you meant "--wtih-vendor-name", is that correct?<br>
<br>
If so, yes; "--with-vendor-name" would still be used for the same
things than it currently is, with the exception of populating the
"CompanyName" RC field *if* "--with-jdk-rc-vendor/company-name" is
also used.<br>
<br>
<pre class="moz-signature" cols="72">--
Frederic Thevenet
Senior Software Engineer - OpenJDK
Red Hat France <a class="moz-txt-link-rfc2396E" href="https://www.redhat.com"><https://www.redhat.com></a>
BAF5 C2D2 0BE0 1715 5EE1 0815 2065 AD47 B326 EB92</pre>
</body>
</html>