<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 2023-12-05 12:30, Frederic Thevenet
wrote:<br>
</div>
<blockquote type="cite" cite="mid:2680b825-a017-47f4-8414-92ef5dadf9da@redhat.com">
<div>
<div class="edit-comment-hide">
<div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block">
<p dir="auto">Hi,</p>
<p dir="auto">I would like to propose a small enhancement to
the way the VersionInfo resources[1] embedded into native
exes and dlls on Windows are populated by the JDK build
for its native components, and more specifically, the
value for the property called "Company name".</p>
<p dir="auto">It is currently always the same as that of
"vendor-name" but it It would be really useful to some
build scenarios to allow for the "company name" property
embedded in the VersionInfo compiled resources to be
different from the "vendor name" property that is used
within the JVM (e.g. java -version).</p>
<p dir="auto">So I'd like to propose the addition of a
"--with-jdk-rc-company-name" configure option which can be
used to set "Company name" to its own value, independently
of "'vendor-name", in the same fashion as the existing
"--with-jdk-rc-name" can be used to override the values of
"File description" and "Product name".</p>
</div>
</div>
</div>
</blockquote>
<p>So this is really a "--with-jdk-rc-vendor-name", since it will
use that value instead of --with-jdk-vendor-name for the RC fields
in Windows binaries?</p>
<p>Would --with-jdk-vendor-name be used for anything at all on
Windows in that case?</p>
<p>/Magnus<br>
</p>
<blockquote type="cite" cite="mid:2680b825-a017-47f4-8414-92ef5dadf9da@redhat.com">
<div>
<div class="edit-comment-hide">
<div class="comment-body markdown-body js-comment-body soft-wrap css-overflow-wrap-anywhere user-select-contain d-block">
<p dir="auto">If "--with-jdk-rc-company-name" isn't used,
then the vendor-name value is used instead, reproducing
the same behavior than without this patch.</p>
<p dir="auto">[1]
<a class="moz-txt-link-freetext" href="https://learn.microsoft.com/en-us/windows/win32/menurc/versioninfo-resource" moz-do-not-send="true">https://learn.microsoft.com/en-us/windows/win32/menurc/versioninfo-resource</a></p>
<p dir="auto">Cheers,</p>
</div>
</div>
</div>
<pre class="moz-signature" cols="72">--
Frederic Thevenet
Senior Software Engineer - OpenJDK
Red Hat France <a class="moz-txt-link-rfc2396E" href="https://www.redhat.com"><https://www.redhat.com></a>
BAF5 C2D2 0BE0 1715 5EE1 0815 2065 AD47 B326 EB92</pre>
</blockquote>
</body>
</html>