<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>To me that sounds like GHA are miss-configured for the update
releases. To work around this, perhaps we should set an explicit
'--release N-1' argument when building source intended to run on
the bootjdk. It looks like we currently set '-source N-1 -target
N-1' but that isn't enough as it won't change the available JDK
APIs to link to.</p>
<p>/Erik<br>
</p>
<div class="moz-cite-prefix">On 8/7/24 6:13 AM, Baesken, Matthias
wrote:<br>
</div>
<blockquote type="cite" cite="mid:AM9PR02MB677047A49073BE20F20A37BC93B82@AM9PR02MB6770.eurprd02.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;
mso-fareast-language:EN-US;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}div.WordSection1
{page:WordSection1;}</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi Erik, thanks for the
clarification.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Unfortunately we do not
see this in GHA , so backports look nice and ‘green’
there .<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">And some people with
strict version requirements in the company most likely have
a problem with an old / unpatched JDK20 .<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards, Matthias<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="mso-ligatures:none;mso-fareast-language:#2000" lang="EN-US">From:</span></b><span style="mso-ligatures:none;mso-fareast-language:#2000" lang="EN-US"> Erik Joelsson
<a class="moz-txt-link-rfc2396E" href="mailto:erik.joelsson@oracle.com"><erik.joelsson@oracle.com></a>
<br>
<b>Sent:</b> Wednesday, 7 August 2024 13:58<br>
<b>To:</b> Baesken, Matthias
<a class="moz-txt-link-rfc2396E" href="mailto:matthias.baesken@sap.com"><matthias.baesken@sap.com></a>; Magnus Ihse Bursie
<a class="moz-txt-link-rfc2396E" href="mailto:magnus.ihse.bursie@oracle.com"><magnus.ihse.bursie@oracle.com></a><br>
<b>Subject:</b> Re: jdk21u-dev build issue : 8326332:
Unclosed inline tags cause misalignment in summary
tables<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Hello Matthias,<span style="mso-ligatures:none;mso-fareast-language:#2000"><o:p></o:p></span></p>
<p>If you had sent this to build-dev, you would have received an
answer much quicker as both Magnus and I were on vacation.<o:p></o:p></p>
<p>No, you can't use JDK N features in the langtools modules
because because those need to be compatible with the official
bootjdk which is version JDK N-1. This has been the case since
long before I started working on the JDK.<o:p></o:p></p>
<p>/Erik<o:p></o:p></p>
<div>
<p class="MsoNormal">On 7/24/24 12:52 AM, Baesken, Matthias
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span lang="EN-US">Hi, w</span><span lang="en-DE">hen building
</span><span lang="EN-US"> the backport to 21u-dev </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE">8326332: Unclosed
inline tags cause misalignment in summary tables</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE"><a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk21u-dev/pull/866__;!!ACWV5N9M2RV99hQ!N6ImKRDmCqe8NMhVHZajZONX-DYbCsHBaMWvQG9P8jGjhveNzlH1ZX1ZtjzkFWHUSB35IB8wb_fY4jsQe_rh1zGFPvw$" moz-do-not-send="true">https://github.com/openjdk/jdk21u-dev/pull/866</a></span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE">with a BOOT JDK 20, I
run into these build errors :</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE">(the build works </span><span lang="EN-US">fine
</span><span lang="en-DE">when a JDK21 is used as BOOT JDK</span><span lang="EN-US"> ; in GHA it is also fine because seems we
use JDK21 boot JDK there
</span><span lang="en-DE">)</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE"> </span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE">/open_jdk/jdk21u_dev_2/jdk21u-dev/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java:1156:
error: cannot find symbol</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE"> &&
openTags.getLast().equals(name)) {</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE"> ^</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE"> symbol: method getLast()</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE"> location: variable openTags of type
List<Name></span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE">/open_jdk/jdk21u_dev_2/jdk21u-dev/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java:1157:
error: cannot find symbol</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE"> openTags.removeLast();</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE"> ^</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE"> symbol: method removeLast()</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE"> location: variable openTags of type
List<Name></span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE">/open_jdk/jdk21u_dev_2/jdk21u-dev/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java:1501:
error: cannot find symbol</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE">
result.add(RawHtml.endElement(openTags.removeLast()));</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE">
^</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE"> symbol: method removeLast()</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE"> location: variable openTags of type
List<Name></span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE">3 errors</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE">gmake[3]: ***
[CompileInterimLangtools.gmk:127:
/open_jdk/jdk21u_dev_2/buildfolder/buildtools/interim_langtools_modules/jdk.javadoc.interim/_the.BUILD_jdk.javadoc.interim_batch]
Error 1</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span lang="en-DE">gmake[2]: *** [make/Main.gmk:78:
interim-langtools] Error 2</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE">We use here
functionality of class List ( getLast() / removeLast() )
that was added in jdk21.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE">Shouldn't we be able
to use this functionality ?</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">For backports it would
be much easier/ cleaner to have the ability of clean
backports without the need to remove jdk21 functionality
.</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Also some people might
not even notice those issues , because they cannot use
old/unpatched/un-secure JDK20 .</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE">It looks like there
might be an issue in the build process</span><span lang="EN-US"> so that we reference java.base from boot
jdk20
</span><span lang="en-DE">, or is it done on purpose that
for CompileInterimLangtools / jdk.javadoc this cannot be
used) ?</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="en-DE"> </span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-US">Best regards, Matthias</span><o:p></o:p></p>
</blockquote>
</div>
</blockquote>
</body>
</html>