Fwd: 2nd and 3rd tier targets
Fredrik Öhrström
oehrstroem at gmail.com
Mon Nov 7 14:27:08 PST 2011
2011/11/7 Jonathan Gibbons <jonathan.gibbons at oracle.com>:
> Having shell scripts makes things convenient for developers on local
> machines, but might make things less convenient when submitting jobs to
> make-oriented build farms.
Yes, we have to take that into account. Perhaps a single target run:
make run TOOL=checkstyle.sh
that redirects to the shell script, would solve the problem.
> It would also be nice if the necessary tools were made available in the same
> way that you talk about compilers and other stuff being made available.
If the tools are big, then yes, they can be part of build-deps. But the
tools mentioned so far, seems to be rather small.
//Fredrik
2011/11/7 Jonathan Gibbons <jonathan.gibbons at oracle.com>:
> Having shell scripts makes things convenient for developers on local
> machines, but might make things less convenient when submitting jobs to
> make-oriented build farms.
>
> It would also be nice if the necessary tools were made available in the same
> way that you talk about compilers and other stuff being made available.
>
> -- Jon
>
>
> On 11/07/2011 12:19 PM, Fredrik Öhrström wrote:
>>
>> 2011/11/7 Jonathan Gibbons<jonathan.gibbons at oracle.com>:
>>>
>>> Right now, I imagine you're all busy on what I could describe as the "1st
>>> tier" targets in the Makefiles -- simply being able to build JDK as
>>> needed
>>> on all platforms.
>>
>> Indeed! :-)
>>
>>> I wonder if you've given thought to supporting and/or providing
>>> additional
>>> interesting targets.
>>>
>>> For example, I could imagine providing "2nd tier" targets which are of
>>> interest to all, but which are not required as part of building JDK.
>>> Running FindBugs or CheckStyle might come into this category.
>>
>> Absolutely. But I would favor creating shellscripts instead and reserve
>> make file targets for build artifacts. We could for example add:
>>
>> common/bin/findbugs.sh
>> common/bin/checkstyle.sh
>>
>> we are already adding
>> common/bin/compareimages.sh
>>
>> These shell scripts could be pure shell script, or run a jar file, and if
>> the
>> jar file does not exist, invoke make to create it.
>>
>>> Then there are
>>> targets specific to a component, which I call "3rd tier" targets. For
>>> example, langtools/make/build.xml has a target to run a utility to
>>> generate
>>> an HTML file containing examples of as many as possible of the
>>> diagnostics
>>> that can be run by javac.
>>
>> Also a shell script, perhaps in langtools/bin?
>>
>> //Fredrik
>
>
More information about the build-infra-dev
mailing list