Fwd: webrevs.2 for macosx changes to jdk7u-osx

[David Holmes]

On 30/11/2011 7:03 PM, Michael McMahon wrote:
> David,
>
> The main review is happening on macosx-port-dev at openjdk.java.net

Is that an initial review or final review? I would expect all this to go 
through the regular channels before being pushed into the mainline repos!.

David

> Thanks,
> Michael.
>
> On 30/11/11 06:47, David Holmes wrote:
>> Michael: where is the non-build review taking place? I hate to see so
>> many changes to the Java code :(
>>
>> On 30/11/2011 7:41 AM, Kelly O'Hair wrote:
>>> Can someone review Michael's makefile changes?
>>
>> Not a full review by any means ...
>>
>> make/common/Defs-linux.gmk:
>> + override LIBDL = -ldl
>>
>> Why the "override"?
>>
>> make/common/Defs.gmk:
>>
>> Would it not make sense to create Defs-macosx.gmk, use it do define
>> all the macosx specific stuff and then include Defs-bsd.gmk? We might
>> be able to get rid of a number of macosx specific changes that way.
>> It's not good to have all the PLATFORM checks we have, but it is worse
>> when you have to add one special case all over the place.
>>
>> ifeq ($(PLATFORM), linux)
>> LDLIBS_COMMON = -ldl
>> endif
>>
>> Shouldn't this have been changed to use LIBDL? (else why are we
>> defining LIBDL - or are we now setting it twice?)
>>
>> make/common/Release.gmk:
>>
>> I don't see Release-macosx.gmk in the webrev? And if we have it, can
>> some of the macosx specific changes to the release targets not go into
>> that file?
>>
>> Defs-utils.gmk:
>>
>> + 136 NM = $(UTILS_CCS_BIN_PATH)nm
>>
>> This needs to be deleted. NM is already set at line 90 inside a
>> conditional.
>>
>> David
>> -----
>>
>>
>>> I've got a bit too much on my plate at the moment, and I suspect
>>> Michael would like to get this
>>> reviewed and in place soon.
>>>
>>> Might be good to know for the build-infra team anyway.
>>>
>>> -kto
>>>
>>>
>>> Begin forwarded message:
>>>
>>>> From: Michael McMahon<michael.x.mcmahon at oracle.com>
>>>> Date: November 29, 2011 5:56:30 AM PST
>>>> To: Kelly O'Hair<kelly.ohair at oracle.com>
>>>> Subject: Fwd: webrevs.2 for macosx changes to jdk7u-osx
>>>>
>>>> Kelly,
>>>>
>>>> I forgot to include you in the original email. There are a number of
>>>> makefile
>>>> changes (and new makefiles) included in this work. So, I was hoping
>>>> you could
>>>> cast an eye over them.. The first two links below are probably all
>>>> you are interested in.
>>>>
>>>> Thanks,
>>>> Michael.
>>>>
>>>>
>>>> -------- Original Message --------
>>>> Subject: webrevs.2 for macosx changes to jdk7u-osx
>>>> Date: Mon, 28 Nov 2011 16:08:35 +0000
>>>> From: Michael McMahon<michael.x.mcmahon at oracle.com>
>>>> To: macosx-port-dev at openjdk.java.net
>>>>
>>>> Hi,
>>>>
>>>> Here is another version of the macosx webrev. This time it includes
>>>> all of the modifications and new files from macosx-port. Hence many
>>>> of the problems pointed out earlier with the inconsistencies
>>>> relative to
>>>> the bsd code
>>>> are gone now. It builds and runs on all platforms and has been
>>>> synced with
>>>> jdk7u-dev (as of Friday Nov 25). I left the // MacOSX comments in
>>>> to highlight changes that people may want to look at more closely.
>>>>
>>>> Lastly, this time I have also included a webrev showing the changes
>>>> relative to macosx-port
>>>> for reference.
>>>>
>>>> Changes relative to jdk7u-osx
>>>> http://cr.openjdk.java.net/~michaelm/7113349/2/jdk7u-osx/modified/
>>>>
>>>> New files
>>>> http://cr.openjdk.java.net/~michaelm/7113349/2/jdk7u-osx/modified/
>>>>
>>>> Changes relative to macosx-port
>>>> http://cr.openjdk.java.net/~michaelm/7113349/2/macosx-port/modified/
>>>>
>>>> Thanks,
>>>> Michael.
>>>>
>>>
>