Ubuntu 12.04 X64

[Kelly O'Hair]

I checked in a file with a single comment line and pushed it into jdk8/build. Seems to work now.

I suspect the patch file created by webrev is broken with empty files.

Not a big deal.

-kto

On Apr 12, 2012, at 6:47 AM, Magnus Ihse Bursie wrote:

> On 2012-04-12 09:27, Magnus Ihse Bursie wrote:
>> On 2012-04-12 03:42, Kelly O'Hair wrote:
>>> I was following my own instructions from
>>>    https://blogs.oracle.com/kto/entry/jdk8_new_build_infrastructure
>>> 
>>>  and ran into a problem.  Does this failure look familiar?
>> Yes, my bad. :-(
>> 
>> I'll fix it right away.
> 
> It turns out this was only partially right.
> 
> I thought you had this problem in the build-infra forest. It appeared there yesterday, when I deleted the empty file Defs-util.gmk, and was fixed this morning (Swedish time) when I removed the reference to Defs-util.gmk.
> 
> However, now it turns out that people are having this problem when building from the build forest, or worse, the jdk8 master forest!
> 
> "How could that be?" I asked myself, with rising panic. I checked the webrev you were supposed to integrate. It contained the empty Defs-util.gmk file (http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jdk-new.01/, search for "Defs-utils.gmk"). But I couldn't really believe that you had integrated the wrong webrev either. So I checked the patch file (http://cr.openjdk.java.net/~erikj/build-infra-m1/webrev-jdk-new.01/jdk.patch), and it does *NOT* contain the Defs-utils.gmk file!!!
> 
> So there you have it. I don't know if this is a problem with patch files, that they can't be used to create new empty files, or if it is a bug in the webrev scripts which generates a correct web page but an incorrect patch file.
> 
> The simplest way to fix this is to create an empty file, as it was in the original build-infra repo. But the correct way is probably to remove the reference.
> 
> I'll prepare two webrevs with both these options, but I'd like to leave it up to you, Kelly, to decide which way to go.
> 
> /Magnus