[8] Review request for 7193601: Build breakage with the fix to 6336885 (build-infra build)

[Mike Duigou]

Looks good to me and from my testing passes basic jtreg tests.

Mike

On Aug 23 2012, at 10:58 , Naoto Sato wrote:

> Created a CR and webrev (no change from yours). Please review.
> 
> http://cr.openjdk.java.net/~naoto/7193601/webrev.00/
> 
> Naoto
> 
> On 8/22/12 4:22 PM, Naoto Sato wrote:
>> Hi Mike,
>> 
>> Sorry, the makefile needs to be fixed as you suggested. Will fix it.
>> 
>> Naoto
>> 
>> On 8/22/12 4:12 PM, Mike Duigou wrote:
>>> Hello Naoto;
>>> 
>>> Following the push
>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/131a683a2ce0 to the jdk8/tl
>>> tree I was unable to build JDK on MacOSX using the new build
>>> infrastructure. I was able to fix the problem with the following change:
>>> 
>>> diff --git a/makefiles/CompileJavaClasses.gmk
>>> b/makefiles/CompileJavaClasses.gmk
>>> --- a/makefiles/CompileJavaClasses.gmk
>>> +++ b/makefiles/CompileJavaClasses.gmk
>>> @@ -256,7 +256,8 @@
>>> EXFILES+=
>>> $(JDK_TOPDIR)/src/solaris/classes/sun/nio/ch/DefaultSelectorProvider.java
>>> \
>>> $(JDK_TOPDIR)/src/solaris/classes/sun/java2d/BackBufferCapsProvider.java
>>> \
>>> $(JDK_TOPDIR)/src/solaris/classes/java/net/DefaultInterface.java \
>>> - $(JDK_TOPDIR)/src/solaris/classes/java/lang/ClassLoaderHelper.java
>>> + $(JDK_TOPDIR)/src/solaris/classes/java/lang/ClassLoaderHelper.java \
>>> +
>>> $(JDK_TOPDIR)/src/solaris/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
>>> 
>>> 
>>> # JObjC.jar contains 1.5 byte-code...so skip it here :-(
>>> # MACOSX_SRC_DIRS += $(JDK_TOPDIR)/src/macosx/native/jobjc/src
>>> 
>>> 
>>> The new build system is probably not quite at the point where all
>>> changes should be built with both the old and new build systems but I
>>> suspect that time is quite soon (and it will come faster if there are
>>> fewer build problems). I have not created an issue for this problem.
>>> 
>>> Mike
>> 
>