Request for Review: Java SE 8 Compact Profiles
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Fri Dec 21 13:25:42 PST 2012
21 dec 2012 kl. 16:18 skrev Kelly O'Hair <kelly.ohair at oracle.com>:
> These comments in Main.gmk don't seem to make sense:
>
> 117 # Note: This double-colon rule is intentional, to support
> 118 # custom make file integration.
> 119 images:: source-tips demos images-only
>
> Do lines 117 and 118 just need to be deleted?
Double-colon rules should be avoided, and in this case their need was not apparent from the file, however, they were needed to support the additional code inserted from our custom makefile. I changed such a double-colon rule to single-colon once, so I find this comment valuable. :)
/Magnus
More information about the build-infra-dev
mailing list