Adding asm to JDK 8

[Kelly O'Hair]

On Feb 6, 2012, at 8:46 AM, Jim Holmlund wrote:

> 
> 
> On 2/6/2012 12:04 AM, David Holmes wrote:
>> On 4/02/2012 5:03 AM, Jim Holmlund wrote:
>>> On 2/2/2012 7:13 PM, David Holmes wrote:
>>>> I added build-dev to the cc as this is of general interest. Actually
>>>> before doing this a heads-up should go out to all jdk8-dev I think.
>>>> 
>>>> One question: are there any cross-compilation issues with building
>>>> this? I'm assuming not but want to check.
>>> I don't know of any such issues. What sort of build scenario are you
>>> thinking of?
>> 
>> When we cross-compile we have to distinguish between tools executed on the build host and those built for the target host. If ASM is pure Java (is it?) then there should not be any such concerns - as long as it doesn't build something in phase N that it has to execute in phase M>N.
>> 
> Ok, thanks for the info.  asm is pure java and has no issues in this area.

Ah... but even if it is pure Java, if it needs to be run in Phase 1 with the BOOT JDK, then it needs to be built
with -target 7.  But if it gets delivered into jdk8 somehow, then it needs to be built with -target 8.
Not a huge deal, just something to keep in mind.

langtools builds a bootstrap javac (-target 6) and one for delivery into the jdk8 image (-target 8).
But jaxp and jaxws, are just built once with -target 8, because it is not run by the BOOT JDK, or isn't yet.

Again, jigsaw may change things.

-kto

> - jjh
> 
>> David
>> -----
>> 
>>> - jjh
>>>> 
>>>> Okay two questions :) : do you know when this will get modularized and
>>>> show up in the jigsaw repositories?
>>>> 
>>>> Thanks,
>>>> David
>>>> 
>>>> On 3/02/2012 9:29 AM, Jim Holmlund wrote:
>>>>> This is just a heads up that we are in the process of adding
>>>>> http://asm.ow2.org/
>>>>> 
>>>>> to jdk 8 as a new top level repo. This new repo contains the asm source
>>>>> code, with a few mods that are needed to build/run it in our
>>>>> environment. The new repo also contains the build files needed to
>>>>> participate in our forest builds. The main building is done by the asm
>>>>> build.xml, with a Makefile wrapper around that in order to participate
>>>>> in the forest build. This Makefile dynamically renames the asm packages
>>>>> by prepending 'org.openjdk'.
>>>>> 
>>>>> The forest build handles the asm repo in the same was as the other
>>>>> repos, eg, corba. The asm repo is built just after langtools, and then
>>>>> the resulting .class files are known in the jdk build and are put into
>>>>> rt.jar.
>>>>> 
>>>>> The changes for this are:
>>>>> - These files are modified/added:
>>>>> M Makefile
>>>>> M make/Defs-internal.gmk
>>>>> M make/README.pre-components
>>>>> A make/asm-rules.gmk
>>>>> M make/jdk-rules.gmk
>>>>> M make/sanity-rules.gmk
>>>>> M make/scripts/hgforest.sh
>>>>> 
>>>>> - the new asm repo is built just after langtools
>>>>> 
>>>>> - these files in the jdk repo are modified/added:
>>>>> M THIRD_PARTY_README
>>>>> M make/Makefile
>>>>> M make/common/Release.gmk
>>>>> M make/common/internal/ImportComponents.gmk
>>>>> M make/common/shared/Defs-control.gmk
>>>>> M make/common/shared/Defs.gmk
>>>>> M make/common/shared/Sanity-Settings.gmk
>>>>> A make/common/internal/Defs-asm.gmk
>>>>> A test/org/openjdk/org/objectweb/asm/OmitCommons.java
>>>>> A test/org/openjdk/org/objectweb/asm/OmitOptimizer.java
>>>>> A test/org/openjdk/org/objectweb/asm/OmitTreeAnalysis.java
>>>>> A test/org/openjdk/org/objectweb/asm/OmitUtil.java
>>>>> A test/org/openjdk/org/objectweb/asm/OmitXml.java
>>>>> A test/org/openjdk/org/objectweb/asm/RequiredAsmClasses.java
>>>>> 
>>>>> These changes have not been reviewed and thus are subject to change.
>>>>> Hopefully, this work can be finished in the next couple weeks. But where
>>>>> have we heard that before.
>>>>> 
>>>>> Please let me know if you have any questions or need more info.
>>>>> 
>>>>> - jjh
>>>>> 
>>>>> 
>>>>>