Minor nit: "Building OpenJDK .."

Kelly O'Hair kelly.ohair at oracle.com
Thu Jul 5 18:34:20 PDT 2012


Filed 

7182054: build-infra: Print more approriate name of what is being built


for this so we don't forget it.

-kto

On Jul 5, 2012, at 11:27 AM, Erik Joelsson wrote:

> Not a major issue no, but I agree that it would be nice, and useful, if it said something more accuratly describing the product being built.
> 
> /Erik
> 
> On 2012-07-04 15:56, David Holmes wrote:
>> common/makefiles/MakefileHelpers.gmk always reports that it is building OpenJDK even if it is not:
>> 
>> define PrintStartMessage
>>    $(if $(VERBOSE),,@$(ECHO) Running make as $(MAKE) $(MFLAGS) $(MAKE_ARGS))
>>    $(call CheckEnvironment)
>>    @$(ECHO) "Building OpenJDK for target $(if $(MAKECMDGOALS),'$(MAKECMDGOALS)','all') in configuration '$(CONF_NAME)'"
>> endef
>> 
>> define PrintEndMessage
>>    @$(ECHO) "Finished building OpenJDK for target '$@'"
>>    $(call CheckEnvironment)
>> endef
>> 
>> 
>> David
>> -----
> 




More information about the build-infra-dev mailing list