hg: build-infra/jdk8: Cleaned up HOST_... variables.

David Holmes david.holmes at oracle.com
Wed Mar 28 03:42:05 PDT 2012


Hi Fredrik,

If these:

+ # LEGACY_HOST_CPU1=i586,amd64,sparc,sparcv9,arm,arm64...
+ # LEGACY_HOST_CPU2=i386,amd64,sparc,sparcv9,arm,arm64...
+ # LEGACY_HOST_CPU3=sparcv9,amd64 (but only on solaris)

equate to BUILDARCH, LIBARCH, PLATFORM_ARCH etc, might it not be better 
to name them more descriptively? No one will recall what 
LEGACY_HOST_CPU2 relates to when they see it in a build file.

David
-----

On 28/03/2012 8:35 PM, fredrik.ohrstrom at oracle.com wrote:
> Changeset: 3cff9abff4aa
> Author:    ohrstrom
> Date:      2012-03-28 12:37 +0200
> URL:       http://hg.openjdk.java.net/build-infra/jdk8/rev/3cff9abff4aa
>
> Cleaned up HOST_... variables.
>
> ! common/autoconf/configure
> ! common/autoconf/configure.ac
> ! common/autoconf/platform.m4
> ! common/autoconf/spec.gmk.in
> ! common/makefiles/NativeCompilation.gmk
>



More information about the build-infra-dev mailing list