build problem

[Erik Joelsson]

No, you misunderstand me. That changeset fixed such a problem in 
CreateJars.gmk. Your error message says spec.gmk, the generated file in 
the build output dir. I'm suspecting that something to do with a path 
with backslashes in it has somehow gotten in there, but it's just a 
guess. I would like to take a look at the resulting spec.gmk regardless 
to try to figure it out.

/Erik

On 2012-11-19 17:43, Phil Race wrote:
> I'm sure that's why Kelly suggested the changeset below .. since it 
> has such a \
> but I already fixed that prior to even trying to build.
>
> -phil.
>
> On 11/19/2012 3:18 AM, Erik Joelsson wrote:
>> My first guess would be a '\' at the end of a line somewhere in the 
>> spec.gmk file that cancels out the endif on the next line. Would be 
>> interesting to see the full spec.gmk regardless. I haven't seen this 
>> happen before in spec but wouldn't be surprised if a backslash from a 
>> path somewhere ended up in the wrong place.
>>
>> /Erik
>>
>> On 2012-11-17 00:28, Phil Race wrote:
>>> I had already applied those two fixes manually and I just
>>> double-checked and they seem to be there ..
>>>
>>> -phil.
>>>
>>> On 11/16/2012 3:21 PM, Kelly O'Hair wrote:
>>>> You need this changeset:
>>>>
>>>> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/1e79fec4a01f
>>>>
>>>>
>>>> -kto
>>>>
>>>> On Nov 16, 2012, at 3:14 PM, Phil Race wrote:
>>>>
>>>>> Can anyone explain what the solution might be to the following
>>>>> build failure on Windows 7 x64. I'm using our current JDK8 2d team 
>>>>> repo :-
>>>>>
>>>>> sh ./configure --with-boot-jdk=c:/jdk1.7
>>>>>
>>>>> make NEWBUILD=true BUILD_DEPLOY=false BUILD_INSTALL=false
>>>>> No checks yet
>>>>> cd 
>>>>> /cygdrive/c/jdks/2d/build/windows-x86_64-normal-server-release/&&  
>>>>> make all
>>>>> make[1]: Entering directory 
>>>>> `/cygdrive/c/jdks/2d/build/windows-x86_64-normal-server-release'
>>>>> /cygdrive/c/jdks/2d/build/windows-x86_64-normal-server-release/spec.gmk:601: 
>>>>> *** missing `endif'.  Stop.
>>>>> make[1]: Leaving directory 
>>>>> `/cygdrive/c/jdks/2d/build/windows-x86_64-normal-server-release'
>>>>> make: *** [all] Error 2
>>>>>
>>>>>
>>>>> line 601 is the last line of spec.gmk and if I add endif 
>>>>> afterwards it seems to
>>>>> at least get past this point but obviously something is wrong.  I 
>>>>> looked over
>>>>> the file and all if's seem balanced to me.
>>>>>
>>>>> Last few lines of the file look like this :- "8(0" looks odd too but
>>>>> changing that doesn't seem to fix my issue.
>>>>>
>>>>> ----
>>>>> # Name of Service Agent library
>>>>> SALIB_NAME=sawindbg.dll
>>>>>
>>>>> OS_VERSION_MAJOR:=1
>>>>> OS_VERSION_MINOR:=7
>>>>> OS_VERSION_MICRO:=8(0
>>>>>
>>>>> # Include the custom-spec.gmk file if it exists
>>>>> -include $(dir 
>>>>> /cygdrive/c/jdks/2d/build/windows-x86_64-normal-server-release/spec.gmk)/custom-spec.gmk
>>>>> -----
>>>>>
>>>>>
>>>>> -phil.
>>>>>
>>>
>