sizer compilation has been broken for cross-compiles

David Holmes david.holmes at oracle.com
Sun Nov 25 17:46:57 PST 2012


This changeset

changeset:   6067:dcee387cde81
user:        ohrstrom
date:        Mon Oct 29 13:41:38 2012 -0700
summary:     8001891: build-infra: Adding X_CFLAGS and X_LIBS to lwawt 
and sizer compilation

diff -r 5b29d6157504 -r dcee387cde81 makefiles/GensrcX11Wrappers.gmk
--- a/makefiles/GensrcX11Wrappers.gmk
+++ b/makefiles/GensrcX11Wrappers.gmk
@@ -64,6 +64,8 @@
         $(MKDIR) -p $(@D)
         $(RM) $@ $@.tmp
         (cd $(@D) && $(BUILD_CC) -m$* -o $@.tmp $< \
+              $(X_CFLAGS) \
+              $(X_LIBS) \
                -I$(JDK_OUTPUTDIR)/include \
                -I$(JDK_TOPDIR)/src/share/javavm/export \
 
-I$(JDK_TOPDIR)/src/$(OPENJDK_TARGET_OS_API_DIR)/javavm/export \

breaks cross-compilation as the values in X_CFLAGS and X_LIBS are those 
of the cross-compiler, not the build machine compiler that will create 
the sizers executable.

Not sure why sizers needs the above even when not cross-compiling - it 
is a very basic program that just needs access to the right header 
files. Does it need special compiler flags or lib options ??

I've filed https://jbs.oracle.com/bugs/browse/JDK-8003958 to track this 
as it has already 'escaped'. I'll have to pull it out of the profiles 
forest for now.

Thanks,
David
-----




More information about the build-infra-dev mailing list