My next, and last problem with building on my cygwin

Erik Joelsson erik.joelsson at oracle.com
Wed Oct 3 03:10:00 PDT 2012


The file in question is generated by a java program, so platform native 
line endings would be expected. The difference is in how grep interprets 
the $ end of line in the regexp.

/Erik

On 2012-10-03 11:03, Magnus Ihse Bursie wrote:
> When you install Cygwin, you can choose between unix or windows line endings. Default is unix, and this is all we have tested build-infra with. It almost sounds as if you have windows line endings. Can you check if this is the case (run Cygwin setup.exe again), and switch to unix?
>
> /Magnus
>
> 29 sep 2012 kl. 02:40 skrev Jim Holmlund<james.holmlund at oracle.com>:
>
>> The jdk CreateJars.gmk file creates a file named _the.jars.contents which contains, well you guessed it, a list of all the contents of a jar file.
>>
>> It then greps for .class files  in this list.  The problem is that on my machine, the lines in _the.jars.contents end with that stupid ^M char.  This prevents  the greps from finding any .class files.
>>
>> I don't know the best fix for this.  I made this change and now I can build thru images successfully:
>>
>>> diff -r d94613ac03d8 makefiles/CreateJars.gmk
>>> --- a/makefiles/CreateJars.gmk    Wed Sep 26 22:22:51 2012 -0700
>>> +++ b/makefiles/CreateJars.gmk    Fri Sep 28 17:33:09 2012 -0700
>>> @@ -305,7 +305,7 @@
>>>      ($(CD) $(JDK_OUTPUTDIR)/classes&&  \
>>>          $(TOOL_JARREORDER) \
>>>          -o  $@.tmp $(JDK_OUTPUTDIR)/lib/classlist $(JDK_OUTPUTDIR)/lib/_the.jars.exclude . )
>>> -    $(MV) $@.tmp $@
>>> +    $(SED) -e 's@\
>>> *$$@@' $@.tmp>  $@
>>>
>>> $(JDK_OUTPUTDIR)/lib/_the.rt.jar.contents: $(JDK_OUTPUTDIR)/lib/_the.jars.contents
>>>      $(MKDIR) -p $(@D)
>> - jjh
>>



More information about the build-infra-dev mailing list