My next, and last problem with building on my cygwin

[Kelly O'Hair]

To clarify my earlier statement, we should NOT allow the use of cygwin 1.5.
It's just not worth the hassles.

-kto

On Oct 3, 2012, at 6:40 PM, Jim Holmlund wrote:

> 
> 
> On 10/3/2012 2:03 AM, Magnus Ihse Bursie wrote:
>> When you install Cygwin, you can choose between unix or windows line endings. Default is unix, and this is all we have tested build-infra with. It almost sounds as if you have windows line endings. Can you check if this is the case (run Cygwin setup.exe again), and switch to unix?
> I ran setup.exe but I didn't see any choices about this.  Per previous email, the grep in 1.7  ignores the ^Ms so I am good on this.  But, I fear that other people might run into the same problem while running older cygwins.
> - jjh
> 
>> 
>> /Magnus
>> 
>> 29 sep 2012 kl. 02:40 skrev Jim Holmlund<james.holmlund at oracle.com>:
>> 
>>> The jdk CreateJars.gmk file creates a file named _the.jars.contents which contains, well you guessed it, a list of all the contents of a jar file.
>>> 
>>> It then greps for .class files  in this list.  The problem is that on my machine, the lines in _the.jars.contents end with that stupid ^M char.  This prevents  the greps from finding any .class files.
>>> 
>>> I don't know the best fix for this.  I made this change and now I can build thru images successfully:
>>> 
>>>> diff -r d94613ac03d8 makefiles/CreateJars.gmk
>>>> --- a/makefiles/CreateJars.gmk    Wed Sep 26 22:22:51 2012 -0700
>>>> +++ b/makefiles/CreateJars.gmk    Fri Sep 28 17:33:09 2012 -0700
>>>> @@ -305,7 +305,7 @@
>>>>     ($(CD) $(JDK_OUTPUTDIR)/classes&&  \
>>>>         $(TOOL_JARREORDER) \
>>>>         -o  $@.tmp $(JDK_OUTPUTDIR)/lib/classlist $(JDK_OUTPUTDIR)/lib/_the.jars.exclude . )
>>>> -    $(MV) $@.tmp $@
>>>> +    $(SED) -e 's@\
>>>> *$$@@' $@.tmp>  $@
>>>> 
>>>> $(JDK_OUTPUTDIR)/lib/_the.rt.jar.contents: $(JDK_OUTPUTDIR)/lib/_the.jars.contents
>>>>     $(MKDIR) -p $(@D)
>>> - jjh
>>>