7179349 misses updating new build makefiles

[Mike Duigou]

On Oct 18 2012, at 01:32 , Leonid Romanov wrote:

> Could you take care of it? I've no idea how the new build system works.

Unfortunately no. I looked in to creating a patch but was unsure how to handle generated source files in the new build or the adding of the -I to the appropriate compiles. I am willing to work with build-infra folks to resolve this though.

Mike

> Besides, no one complained about the fix when I sent it for a review… Btw, ToBin.java is a modified copy of <jdk>/make/sun/xawt/ToBin.java, so if you decide to go with your suggestion, you probably want to replace the original ToBin.java as well. 
> 
> On 18.10.2012, at 6:45, Mike Duigou <mike.duigou at oracle.com> wrote:
> 
>> A fix was recently integrated into JDK 8 mainline repo which breaks new-infra builds on MacOS X.
>> 
>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d6cba7bfbb3d
>> 
>> The logic for creating the icon file created is not present in the new build infra makefiles. (jdk/makefiles)
>> 
>> The ToBin.java program can also be omitted with something like the following:
>> 
>> (/bin/echo "static unsigned char sAWTIconData[] = {"; hexdump -v -e '"\t" 32/1 "%u, " "\n"' $(ICON) ; /bin/echo "};") > $(ICON_DATA)
>> 
>> Mike
>