7179349 misses updating new build makefiles

[Kelly O'Hair]

This is more complicated than it looks. First off, these changes have not been merged into build-infra yet,
so I can't fix it there right now. And I'm reluctant to fix it anywhere but in build-infra right now.

From what I can tell, Leonid created a new java Build tool ToBin, which should have been added as a new formal
build tool like the others we have. But we already have a tool called ToBin for X11 icons, so now we have 2. :^(

Then a mac binary icon file was added to an open repository. Binary files are not really recommended in open repositories
but we apparently do have others, so I guess this is ok.

If you need to get around this quickly, I recommend you backout this changeset.
e.g.
   hg backout --rev d6cba7bfbb3d
   hg merge
   hg commit -m Merge

-kto

On Oct 22, 2012, at 1:13 PM, Mike Duigou wrote:

> Ping!
> 
> Anyone from build-infra group able to answer any of my questions below so that this can be resolved?
> 
> Having a busted new build-infra on MacOSX for all jdk8 repos is unacceptable.
> 
> Mike
> 
> On Oct 18 2012, at 14:37 , Mike Duigou wrote:
> 
>> 
>> On Oct 18 2012, at 10:54 , Kelly O'Hair wrote:
>> 
>>> ALL Makefile and build changes need to be reviewed by the build-dev at openjdk.java.net team.
>>> 
>>> This gives us a heads up, and the build-infra team can red-flag when we see an issue.
>>> 
>>> I've sent out more global email on this topic.
>>> 
>>> Has a bug been filed on this regression in the build-infra build?
>> 
>> I have created JDK-8001158 for this issue.
>> 
>>> (I'm kind of short handed on the build-infra team right now, so anyone able to help out here would be great)
>> 
>> I took another look at modifying CompileNativeLibraries.gmk but couldn't work out the correct handling of a couple of things:
>> 
>> 1. Where the generated source (AWTIconData.h) should properly go.
>> 
>> 2. Where the production rule for generating the AWTIconData.h should live
>> 
>> 3. How to modify the SetupNativeCompilation call to add in the -I for the gensrc dir containing AWTIconData.h
>> 
>> 4. Proper clean/clobber rules for the AWTIconData.h file.
>> 
>>> 
>>> -kto
>>> 
>>> On Oct 17, 2012, at 7:45 PM, Mike Duigou wrote:
>>> 
>>>> A fix was recently integrated into JDK 8 mainline repo which breaks new-infra builds on MacOS X.
>>>> 
>>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/d6cba7bfbb3d
>>>> 
>>>> The logic for creating the icon file created is not present in the new build infra makefiles. (jdk/makefiles)
>>>> 
>>>> The ToBin.java program can also be omitted with something like the following:
>>>> 
>>>> (/bin/echo "static unsigned char sAWTIconData[] = {"; hexdump -v -e '"\t" 32/1 "%u, " "\n"' $(ICON) ; /bin/echo "};") > $(ICON_DATA)
>>>> 
>>>> Mike
>>> 
>> 
>