Make File Changes For CR4239752
Dan Xu
dan.xu at oracle.com
Mon Oct 22 17:03:19 PDT 2012
I just cleaned the build by running "make dist-clean" command, and then
configure and re-make jdk. But the error still exists.
Here is the error message,
> c:/cygwin/home/danxu/dev/Jdk/tl8/jdk/src/windows/native/java/io/WinNTFileSystem_md.c(46)
> : fatal error C1083: Cannot open include file: 'java_io_FileSystem.h':
> No such file or directory
> mlib_ImageAffine_NN.c
> c:/cygwin/home/danxu/dev/Jdk/tl8/jdk/src/share/native/common/jdk_util.c(61)
> : warning C4267: 'initializing' : conversion from 'size_t' to 'int',
> possible loss of data
> mlib_ImageAffine_NN_Bit.c
> CompileNativeLibraries.gmk:225: recipe for target
> `/cygdrive/c/cygwin/home/danxu/dev/Jdk/tl8/build/windows-x86_64-normal-server-release/jdk/objs/libjava/WinNTFileSystem_md.obj'
> failed
> make[2]: ***
> [/cygdrive/c/cygwin/home/danxu/dev/Jdk/tl8/build/windows-x86_64-normal-server-release/jdk/objs/libjava/WinNTFileSystem_md.obj]
> Error 2
It seems that the java_io_FileSystem.h is not generated automatically
after my change. Before the change, I can see this header file was
generated under
build/windows-x86_64-normal-server-release/jdk/gensrc_headers/
directory. I wonder how the header file is generated in the build. Thanks!
-Dan
On 10/22/2012 04:21 PM, Kelly O'Hair wrote:
> I agree Magnus, should have worked.
> It looks like makefiles/mapfiles/libjava/mapfile-vers was changed, and that should do it.
> I assume the .so is dependent on the mapfiles right?
>
> ---
>
> Dan,
>
> If a clean build fails, please send us cut&paste of the error.
>
> -kto
>
> On Oct 22, 2012, at 4:12 PM, Magnus Ihse Bursie wrote:
>
>> Dan,
>>
>> This does not look like a change that should require any changes to the Makefiles in build-infra.
>>
>> Did you try "make clean" before building with your fixes? I think there are some issues with the automatic removing of generated header files when the last native method is removed from a class.
>>
>> /Magnus
>>
>> 23 okt 2012 kl. 00:12 skrev Dan Xu <dan.xu at oracle.com>:
>>
>>> Hi,
>>>
>>> I have a bug fix which needs make file changes, which can be reviewed at http://cr.openjdk.java.net/~dxu/4239752/webrev/.
>>>
>>> With the above make file changes, I am able to build jdk successfully in old build system. But if I built it using new build system, the build process failed and complained about missing generated header file, java_io_FileSystem.h.
>>>
>>> I wonder how I can make the equivalent make file changes in the new build-infra Makefiles. Thanks!
>>>
>>> -Dan
More information about the build-infra-dev
mailing list