hg: build-infra/jdk8/jdk: Added in mac icon generation.

Kelly O'Hair kelly.ohair at oracle.com
Mon Oct 22 20:02:12 PDT 2012


It was not clear to me that they were mutually exclusive, I have been fooled before on this.
I felt that these were X11 icons so I changes the variable names to make that obvious.

I would not have written this GensrcIcons.gmk file in such a way, I feel it is overly complicated right now.

-kto

On Oct 22, 2012, at 7:47 PM, David Holmes wrote:

> Kelly,
> 
> Given X11 and OSX are mutually exclusive platform characteristics did we really have to duplicate all the GEN_ICON stuff into two flavours instead of just changing the actual tool and target based on the OS?
> 
> David
> 
> On 23/10/2012 12:36 PM, kelly.ohair at oracle.com wrote:
>> Changeset: 32d123b84096
>> Author:    ohair
>> Date:      2012-10-22 19:36 -0700
>> URL:       http://hg.openjdk.java.net/build-infra/jdk8/jdk/rev/32d123b84096
>> 
>> Added in mac icon generation.
>> 
>> ! makefiles/GensrcIcons.gmk
>> + src/macosx/native/sun/osxapp/resource/icons/JavaApp.icns
>> 




More information about the build-infra-dev mailing list