RT_JAR_EXCLUDES

[Magnus Ihse Bursie]

Hi Alan,

I think this one fell between the cracks.

Build-infra team, I think Alan has a point here. If this was added to 
the exclude list, it might be due to us compiling stuff we shouldn't 
compile. Otherwise, the exclude seems pointless and should be removed.

/Magnus

On 2012-09-11 12:31, Alan Bateman wrote:
>
> In CreateJars.gmk I see this:
>
> ifeq ($(OPENJDK_TARGET_OS), macosx)
>         RT_JAR_EXCLUDES += com/sun/nio/sctp \
>                            sun/nio/ch/sctp \
>                            sun/jdbc \
> sun/nio/ch/DevPollArrayWrapper\$$$$Updator.class \
>                            sun/nio/ch/DevPollArrayWrapper.class \
>                            sun/nio/ch/DevPollSelectorImpl.class \
> sun/nio/ch/DevPollSelectorProvider.class \
> sun/nio/ch/EPollArrayWrapper\$$$$Updator.class \
>                            sun/nio/ch/EPollArrayWrapper.class \
>                            sun/nio/ch/EPollSelectorImpl.class \
>                            sun/nio/ch/EPollSelectorProvider.class
> endif
>
> I'm curious about the DevPoll* and EPoll* here as they should not be 
> compiled on Mac. We do have issues with implicit compilation of 
> src/solaris/classes/sun/nio/ch/DefaultSelectorProvider.java with the 
> result that Solaris and Linux builds end up with additional classes in 
> rt.jar but that class should not be compiled on Mac 
> (src/macosx/classes/sun/nio/ch/DefaultSelectorProvider.java should be 
> compiled instead). I'm  just wondering if they should be removed from 
> RT_JAR_EXCLUDES?
>
> One other thing in passing, I see several sun.security.ec classes are 
> being added to RT_JAR_EXCLUDES too. As it happens there are a couple 
> of issues in this area that I was talking to Vincent Ryan about 
> recently. He's going to sort them out soon via 7197245, after which I 
> assume that RT_JAR_EXCLUDES can be trimmed.
>
> -Alan.
>
>