OpenJDK build and libfreetype

[Magnus Ihse Bursie]

Just to clarify:

If you are building with closed source, freetype is not used. If you 
specify a freetype flag, it is ignored, and a warning: "Freetype is not 
needed and the flag is ignored" is printed.

If freetype *is* needed, but not found, a fatal configure error will occur.

Since David was building open-only, freetype was indeed required, and 
configure should not have accepted a broken freetype location.

/Magnus


On 2012-10-25 18:28, Kelly O'Hair wrote:
> Please be careful on the error checks in configure.
>
> I pass in the freetype options all the time, even when building the custom jdk, that's because I often never know
> if I have a pure open or custom forest when I spin up a build, so I'm never sure if I need freetype or not.
> I assume that the freetype settings will be ignored if not needed, maybe spit out a warning, but NOT throw a
> fatal error.
>
> Fatal errors should always be reserved for items that are guaranteed to be a build failure.
> If you tighten up the error checking on configure too much, you will only make life difficult for those
> of us that have to work in multiple worlds or varying situations.
>
> The original Sanity checks in the old Makefiles used to be extremely strict, fatal errors for the slightest
> variation on a version of a tool used etc.  When we open sourced, we quickly discovered that we had
> to lighten up a bit, and many fatal sanity errors became warnings. The variations of how the source
> was built and the various systems it was built on, made the fatal sanity checks unmaintainable.
> Now maybe we went too far here, but we need to be careful we don't swing the pendulum back too far.
>
> -kto
>
> On Oct 25, 2012, at 9:06 AM, Magnus Ihse Bursie wrote:
>
>> Freetype is not used when building with closed sources, so it has not been finding itself, it has never been used. Still, it's weird that configure let you pass without a valid freetype path. What did configure print while checking freetype?
>>
>> /Magnus
>>
>> 25 okt 2012 kl. 03:20 skrev David Holmes <david.holmes at oracle.com>:
>>
>>> On 24/10/2012 9:49 PM, Magnus Ihse Bursie wrote:
>>>> On 2012-10-24 03:16, David Holmes wrote:
>>>>> Probably a FAQ but I just tried to force an OpenJDK build of my forest
>>>>> and it failed:
>>>>>
>>>>> /usr/bin/ld: cannot find -lfreetype
>>>>>
>>>>> what do I have to set to make this work?
>>>> You have to specify --with-freetype to configure, pointing to your
>>>> freetype installation.
>>> I don't normally so it is finding it itself for non-openjdk builds.
>>>
>>>> I'm not sure why a missing freetype wasn't caught by configure, though.
>>> Me neither. All I'm changing is whether it is an openjdk build or not.
>>>
>>> The good news is that --with-java-path fixed it for me.
>>>
>>> David
>>>
>>>> On the other hand, the freetype handling in configure is currently
>>>> really crappy, so I'm not surprised. (I'm hoping I'll have enough time
>>>> to fix that before I leave.)
>>>>
>>>> /Magnus