Changes to be pushed into jdk8/build

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Sep 13 03:04:44 PDT 2012


On 2012-09-13 10:12, Magnus Ihse Bursie wrote:
> On 2012-09-13 02:09, David Holmes wrote:
>> jdk/src/share/demo/jvmti/hprof/hprof_init.c
>>
>> Not sure what this change has to do with anything :) Seems like the 
>> code involved here is pretty confused about data type sizes.
> Yeah. I wonder who changed this and why.

It was Kelly, with the intent of supressing a warning (or error?) on 
Mac. My guess is that the compiler might have found it a bit superfluous 
to check if a unsigned short is ever > 65535. So the change seems sound, 
since otherwise that check will never happen (and too large numbers will 
just overflow). I'm not sure if it should be done as part of this push, 
thouh.

/Magnus



More information about the build-infra-dev mailing list