Hotspot build stutter
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Fri Sep 14 05:45:01 PDT 2012
On 2012-09-14 14:35, David Holmes wrote:
> Magnus,
>
> I think this is the new HotspotWrapper.gmk:
>
> $(HOTSPOT_OUTPUTDIR)/_hotspot.timestamp: $(HOTSPOT_FILES)
> @($(CD) $(HOTSPOT_TOPDIR)/make && $(BUILD_LOG_WRAPPER)
> $(MAKE) -j1 $(HOTSPOT_MAKE_ARGS) SPEC=$(HOTSPOT_SPEC)
> BASE_SPEC=$(BASE_SPEC))
> $(TOUCH) $@
>
> Here we invoke the sub-make using the build-log-wrapper, but we're
> already executing in the build-log-wrapper, so any output would, I
> think, go to both build logs - and as the log file is the same we get
> the double output.
Good catch! Thank you! Of course you are right, my bad. :( We don't need
to re-execute the log wrapper. Too much copy/paste here...
I'll fix.
/Magnus
More information about the build-infra-dev
mailing list