hg: build-infra/jdk8: In get_souce.sh, prevent hang by preemptive check for locked repositories.

[David Holmes]

On 18/09/2012 7:10 PM, Magnus Ihse Bursie wrote:
> On 2012-09-18 10:54, fredrik.ohrstrom at oracle.com wrote:
>> Changeset: 4d608b2d7383
>> Author: ohrstrom
>> Date: 2012-09-18 10:53 +0200
>> URL: http://hg.openjdk.java.net/build-infra/jdk8/rev/4d608b2d7383
>>
>> In get_souce.sh, prevent hang by preemptive check for locked
>> repositories.
>>
>> ! get_source.sh
>> + make/scripts/verifyforest.sh
>>
> Isn't it a bit of a "shotgun approach" of doing a find of all files in
> the whole forest to find the lock files in .hg? It seems much speedier
> to just check the .hg directories in the sub repos; they are just a few
> and are known to the forest script.
>
> I'm worried that this might be unneccessary slow on slow system.

I don't understand what this is supposed to be doing. Are "you" using 
get_source.sh as a way to "hg pull" after a clone? Otherwise until 
you've cloned the repos there won't be any to search for these lock 
files. And these are your local repos so if they are locked, who is 
locking them ??

David

> /Magnus