hg: build-infra/jdk8: In get_souce.sh, prevent hang by preemptive check for locked repositories.

Kelly O'Hair kelly.ohair at oracle.com
Tue Sep 18 09:25:21 PDT 2012


On Sep 18, 2012, at 7:48 AM, Jonathan Gibbons wrote:

> On 09/18/2012 02:10 AM, Magnus Ihse Bursie wrote:
>> On 2012-09-18 10:54, fredrik.ohrstrom at oracle.com wrote:
>>> Changeset: 4d608b2d7383
>>> Author:    ohrstrom
>>> Date:      2012-09-18 10:53 +0200
>>> URL: http://hg.openjdk.java.net/build-infra/jdk8/rev/4d608b2d7383
>>> 
>>> In get_souce.sh, prevent hang by preemptive check for locked repositories.
>>> 
>>> ! get_source.sh
>>> + make/scripts/verifyforest.sh
>>> 
>> Isn't it a bit of a "shotgun approach" of doing a find of all files in the whole forest to find the lock files in .hg? It seems much speedier to just check the .hg directories in the sub repos; they are just a few and are known to the forest script.
>> 
>> I'm worried that this might be unneccessary slow on slow system.
>> 
>> /Magnus
> 
> 
> Rather than "find .", I tend to use something more like "ls {.,*,*/*}/LICENSE" to search the top few directories that might contain the files of interest.
> 
> -- Jon

yes I agree, that was the way I wrote the scripts, to avoid the 'find' looking all over the 50,000+ files.

-kto





More information about the build-infra-dev mailing list