Build numbers and milestones

[Erik Joelsson]

I'm not very familiar with the process for version numbers, but I agree. 
Those particular numbers shouldn't be hardcoded into the repo. I believe 
they were set just as placeholders until we figured out how to deal with it.

/Erik

On 2012-09-21 08:04, David Holmes wrote:
> I was baffled as to why my environment variables for setting the build 
> number and milestone (which are traditionally set this way) were not 
> getting picked up by the build.
>
> Finally realized that the include of version.numbers was wiping them out:
>
> JDK_BUILD_NUMBER=
> MILESTONE=internal
>
> I've deleted the above lines locally. I think they should either be 
> deleted formally or else only set if not already set. You don't expect 
> either of these values to be written into version file in the repo 
> (unless you are expecting them to be updated for every build as the 
> hotspot version info is?).
>
> David