suggestion and offer: langtools in build

[Erik Joelsson]

On 2013-01-24 11:04, Fredrik Öhrström wrote:
> Yes, this has bugged me too! The jars existed because of the incremental
> conversion of the old build system. Now we no longer need the jars. We
> can simply
> do
>     "bootclasspath/p:javac.jar -cp javac.jar com.sun.tools.javac.Main"
> instead.
>
> So I here are the few webrevs to do this. We can push all but
> langtools into the build forest,
> and when all has been promoted through master down to langtools, we
> can push the
> langtools repo into tl.
>
> http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-root/
> http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-langtools/
> http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-corba/
> http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-jaxp/
> http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-jaxws/
> http://cr.openjdk.java.net/~ohrstrom/webrev-runjavac-jdk/
>
Oh, if you want to fix this, I'm happy.
> Anyone know why JAVAC_JARS (new name RUN_JAVAC) are ?= assigned?
> are we overriding them in some use cases?
>
I think that the intention has been to put JAVAC_JARS in some central 
location, but it hasn't happened. I would very much like to see it moved 
to spec or similar so that each project won't need to know how to 
construct the command line.

/Erik
> //Fredrik
>
> 2013/1/24 Jonathan Gibbons<jonathan.gibbons at oracle.com>:
>> OK, I'll add the code to langtools; you can utilize it in the build when you
>> have time.
>>
>> -- Jon
>>
>>
>> On 01/23/2013 05:48 PM, Kelly O'Hair wrote:
>>> Sounds like a swell idea to me.
>>>
>>> -kto
>>>
>>> On Jan 23, 2013, at 3:47 PM, Jonathan Gibbons wrote:
>>>
>>>> OK, I realize you guys are really busy right now, so you may want to save
>>>> this for a bit later ...
>>>>
>>>> It bugs me that the new build creates lots of jar files for langtools,
>>>> that only differ in the main program.
>>>>
>>>>    updating 1739 files
>>>>    updating 1739 files
>>>>    updating 1739 files
>>>> Modifying langtools/dist/lib/classes.jar
>>>>    updating 1749 files
>>>>
>>>> How about changing it so that we create a single jar file (classes.jar)
>>>> that contains a "build-time only" main program which is a wrapper for all
>>>> the necessary tools, such that the first arg identifies the tool.
>>>>
>>>> Thus the downstream use is simply to replace
>>>>
>>>>      BOOTJAVAHOME/bin/java -jar javac.jar args
>>>>
>>>> with
>>>>
>>>>      BOOTJAVAHOME/bin/java -jar classes.jar javac args
>>>>
>>>> If you (build-infra guys) are interested, I'll provide the main program
>>>> to go in the langtools repo. This would be for the build only -- there is no
>>>> suggestion to put it in any external product.
>>>>
>>>> -- Jon
>>