Old build blues: build-related code review request for 8001614: Include annotation type to documented supported-ness

Joe Darcy joe.darcy at oracle.com
Wed Jan 30 18:59:33 PST 2013


Hello,

For JDK 8, I'm trying to add a new type in the "jdk" package.  The new 
type is an annotation type to track supported-ness; the contents of the 
type itself have already been reviewed by Jon and Alan.

I'm putting the file into the langtools repository so it can potentially 
be used by both JDK-specific code in langtools and in jdk.  If the new 
type was placed in the jdk repo, it would not be visible to langtools 
during the bootstrapping process.

With the new build, I can just put the file in the appropriate place in 
langtools and it gets picked up by the build and placed in rt.jar, etc. 
(There is a still a limitation, but I'll get to that later.)

With the old, the new file doesn't get picked up automatically.  I 
adjusted the directory list in make/Makefile-classic, and the new file 
does get picked up for javac.jar, but does *not* get propagated into rt.jar.

So my questions include:

* Should the old build system be modified to pick up this file?
* If so, what else is needed to get the file into rt.jar?

The limitation under the new build is that while Supported.class ends up 
in rt.jar, it is not visible during the bootstrapping stage when we 
would like it to be (so com.sun.source.* can be annotated with 
@Supported).  What changes to the new build are needed to allow the type 
to be visible during bootstrapping too?

Current webrev is at:

     http://cr.openjdk.java.net/~darcy/8001614.0/

Thanks,

-Joe



More information about the build-infra-dev mailing list