8007097: (profiles) Build needs test to ensure that profile definitions are updated

[David Holmes]

On 31/01/2013 12:00 AM, Alan Bateman wrote:
> On 30/01/2013 13:04, David Holmes wrote:
>> Hi Alan,
>>
>> This all looks good. My only comments are in Images.gmk. This seems a
>> rather awkward way of making sure that the check happens after the
>> jars exist:
>>
>> + PROFILE_JARS := $(filter %.jar, $(JRE_LIB_TARGETS))
>> +
>> + PROFILE_JARS_CHECKED := $(IMAGES_OUTPUTDIR)/lib$(PROFILE)/_jars_checked
>> +
>> + $(PROFILE_JARS_CHECKED) : $(PROFILE_JARS)
>>
>> You could just add the toolcheck as the recipe for the presently-empty
>> profiles-image target?
> That would mean it would run every time where it should only run when
> the profile images are updated.

True but would that make any real difference. If you do:

make profiles
make profiles

then it will run the second time unnecessarily. But normally you would do

make profiles
<change something>
make profiles

in which case if any class gets compiled and a jar rebuilt then it will 
run anyway.

Not a big deal regardless. I just find those dependency constructions 
quite horrid. :)

David
-----

>>
>> Also note that PROFILE_JARS is already a variable in Profiles.gmk
>> which is included by Images.gmk. I don't think the two uses will
>> conflict but it would be confusing to have them both use the same
>> variable.
> Thanks, I didn't see this in Profiles.gmk. In that case I'll rename it
> to PROFILE_IMAGES_JARS to avoid the confusion.
>
> -Alan.