JDK-8025705

David Holmes david.holmes at oracle.com
Thu Apr 17 01:15:07 UTC 2014


Hi Keith,

On 17/04/2014 7:13 AM, Keith McGuigan wrote:
> Hello,
>
> I just added a comment to this bug -- see there for the details, but in
> short I'd like to update a number of tests in the makefiles that check
> OPENJDK and change them to check instead of the inverse definition of some
> new variable, such as ORACLEJDK.

Please no! It's bad enough this is implicitly in the build without 
making it explicit!

Would file existence tests suffice? There should be a CUSTOM_SRC 
variable for src/closed as there is CUSTOM_MAKE for make/closed.

> This would simply non-OpenJDK (i.e.,
> src/closed builds), non-Oracle builds for those who are making their own
> distributions using the src/closed mechanism.  As you can guess, that is
> something we are doing here at Twitter :)

Hopefully you use src/custom (or whatever) not src/closed, as otherwise 
there's no way to tell the difference between our custom sources and yours.

David
-----

> If I were to put together a patch that does this, could someone work with
> me in getting it integrated into jdk9?  Also, what is the process to
> backport it to the jdk8u repositories?
>
> --
> - Keith
>


More information about the build-infra-dev mailing list