RFR: AIX: fixes and improvements for the new HS build

[Volker Simonis]

On Tue, Feb 9, 2016 at 2:02 PM, Magnus Ihse Bursie
<magnus.ihse.bursie at oracle.com> wrote:
> On 2016-02-08 18:08, Volker Simonis wrote:
>>
>> Hi,
>>
>> I'd like to suggest the following fixes and improvements for the new
>> HS build on AIX:
>>
>>
>> http://cr.openjdk.java.net/~simonis/webrevs/2016/AIX_new_hs_build_top_level/
>> http://cr.openjdk.java.net/~simonis/webrevs/2016/AIX_new_hs_build_hotspot/
>>
>> The changes shouldn't affect any other platform. I've rebased them to
>> the build-infra state of today afternoon.
>>
>> The changes require the re-generation of generated-configure.sh so I'm
>> not sure if I should push this or if you want to sponsor the change.
>
> Since the generated configure changes several times an hour right now ;-) it
> might be easier that I push it for you.
>

Sure, please go ahead.

> The changes look good, I just have two remarks:
> 1) in flags.m4:
>     COMPILER_BINDCMD_FILE_FLAG=
> I think it's more evident that it was explicitely left empty by using:
>     COMPILER_BINDCMD_FILE_FLAG=""
>
> I'll change that before pushing, I hope you don't mind.
>

I'm fine with that.

> 2) I just wanted to point out that with the new COMPILER_BINDCMD_FILE_FLAG
> functionality, you'll start getting loadmaps for all libraries and not only
> libjvm.so. But I guess that doesn't really matter.
>

Yes, it's fine. That file only contains some information like the
number of symbols and so on. It is useful for debugging problems and
not too big.

Regards,
Volker

>> I'd like to express my thankfulness once again for the great work
>> you've already put into supporting AIX and ppc64.
>
> You did some good start, and we tried not to break it. :)
>
> /Magnus