From roman at kennke.org  Tue Apr  3 03:16:46 2012
From: roman at kennke.org (Roman Kennke)
Date: Tue, 03 Apr 2012 12:16:46 +0200
Subject: popups
In-Reply-To: <055789E67C677541B9E81A1E55966D5107DFA1FC@exchange-2.Entero.com>
References: <055789E67C677541B9E81A1E55966D5107DF9FFC@exchange-2.Entero.com>
	<1332966280.17876.73.camel@mercury.localdomain>
	<055789E67C677541B9E81A1E55966D5107DFA1FC@exchange-2.Entero.com>
Message-ID: <1333448206.2478.79.camel@mercury.localdomain>

Hi Glen,

> FEST uses right click, i.e. in BasicRobot.showPopupMenu
> 
>     click(invoker, location, RIGHT_BUTTON, 1);
> 
> So I would vote to just use right click for now.
> 
> I was playing around with the source and hacked in what I think is right for setting the popup value in the MouseEvent.  We noticed a problem in CTCRobotPeer.mouseRelease where it was using the wrong values to set currentModifiers and also moved where it was setting that value to after the event was sent.
> 
> Attached is the patch file along with some tests.

Sorry for the delay. The change looks good. I wanted to push your change
some days ago already, but apparently something got broken in OpenJDK's
repository setup, I currently don't have push rights. As soon as that is
fixed, I will push your changes (along with some minor fixes I have made
to the project setup).

Following that, I will make a release and upload Cacio to the
Sonatype/Maven Central repository so that it can actually be used from
Maven.

Cheers,
Roman




From neugens.limasoftware at gmail.com  Tue Apr  3 04:01:32 2012
From: neugens.limasoftware at gmail.com (neugens.limasoftware at gmail.com)
Date: Tue, 03 Apr 2012 11:01:32 +0000
Subject: hg: caciocavallo/ng: 2 new changesets
Message-ID: <20120403110133.A7A4D47CFB@hg.openjdk.java.net>

Changeset: 4985cb05aaf3
Author:    Roman Kennke <rkennke at redhat.com>
Date:      2012-03-30 12:26 +0200
URL:       http://hg.openjdk.java.net/caciocavallo/ng/rev/4985cb05aaf3

Use CacioFontManager when running on Linux to get around a bug in X11FontManager that causes JDK to crash.

+ cacio-shared/src/main/java/sun/awt/peer/cacio/CacioFontManager.java
! cacio-shared/src/main/java/sun/awt/peer/cacio/CacioToolkit.java
- cacio-web/src/main/java/net/java/openjdk/awt/peer/web/WebFontManager.java
! cacio-web/src/main/java/net/java/openjdk/cacio/server/CacioServer.java

Changeset: b03570484a72
Author:    Roman Kennke <rkennke at redhat.com>
Date:      2012-03-30 13:46 +0200
URL:       http://hg.openjdk.java.net/caciocavallo/ng/rev/b03570484a72

Removed obsolete Eclipse project settings (use Maven now).

- .classpath
- .project
- .settings/org.eclipse.jdt.core.prefs
- .settings/org.eclipse.jdt.ui.prefs



From gschrader at gmail.com  Wed Apr  4 19:49:43 2012
From: gschrader at gmail.com (Glen Schrader)
Date: Wed, 4 Apr 2012 20:49:43 -0600
Subject: focus after closing a dialog
Message-ID: <CAAx7CFvrL3gouZDBtN-H0WF-NoYZP8CbCzaPXWb7_zxd8TkK8g@mail.gmail.com>

Hi,

Here is another patch that contains a test of another problem I'm
having of being able to focus on a component after a dialog is closed.
 I know my fix is likely very wrong, it would appear some events
should be being generated that aren't and I'm just bypassing the
SNFH_FAILURE case in CacioComponentPeer to force it.  I'm still trying
to understand how the focus management is handled and unfortuantely I
get lost easily.  Hopefully there is a more obvious fix or perhaps you
can point me in the right direction.

Thanks,
Glen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DialogFocusLost.patch
Type: application/octet-stream
Size: 4214 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/caciocavallo-dev/attachments/20120404/94c216e1/DialogFocusLost.patch 

From arjanen.loic at gmail.com  Fri Apr  6 03:12:37 2012
From: arjanen.loic at gmail.com (=?UTF-8?Q?ARJANEN_Lo=C3=AFc_Jean_David?=)
Date: Fri, 6 Apr 2012 12:12:37 +0200
Subject: Question about backends
Message-ID: <CAB2q81Z3eT_WZ49jZNpWOmBdqcW0UiZcMkmd_ODOmMmjPx_z-A@mail.gmail.com>

Hello,

I have read here (http://ladybug-studio.com/caciocavallo/) that there
is a DirectFB peer for Caciocavallo and I would like to know where can
I find it. I ask that question because a pet project of mine is to
implement a curses backend and I think it would be useful to take
inspiration on another backend not using X.

Regards,

-- 
ARJANEN Lo?c Jean David
http://luigiscorner.wordpress.com
---
"Computer science is no more about computers than astronomy is about
telescopes, biology is about microscopes, or chemistry is about
beakers and test tubes. Science is not about tools. It is about how we
use them, and what we find out when we do."
Michael R. Fellows and Ian Parberry


From neugens.limasoftware at gmail.com  Fri Apr  6 04:45:17 2012
From: neugens.limasoftware at gmail.com (Mario Torre)
Date: Fri, 6 Apr 2012 13:45:17 +0200
Subject: Question about backends
In-Reply-To: <CAB2q81Z3eT_WZ49jZNpWOmBdqcW0UiZcMkmd_ODOmMmjPx_z-A@mail.gmail.com>
References: <CAB2q81Z3eT_WZ49jZNpWOmBdqcW0UiZcMkmd_ODOmMmjPx_z-A@mail.gmail.com>
Message-ID: <CAGUMyaQevuFimK4gvVrdSbBoG6ntTqbWKXdJpk1BAwbXVwihzA@mail.gmail.com>

Hi Arjanen,

The DirectFB backend is currently still closed source. We are working
on a Free Software replacement but at this moment I can't tell you
when this will be ready.

There is an SDL backend, which it's very uncomplete, and probably
doesn't fully work anymore, but it's still very good as a
tutorial-like peer for new Cacio developers so we keep it around.

You can also give a look at the web and test backend, which are the
most complete peers, but probably the SDL is the best place to start.

Of course, if you have any question, we will be very happy to help you!

Cheers,
Mario

2012/4/6 ARJANEN Lo?c Jean David <arjanen.loic at gmail.com>:
> Hello,
>
> I have read here (http://ladybug-studio.com/caciocavallo/) that there
> is a DirectFB peer for Caciocavallo and I would like to know where can
> I find it. I ask that question because a pet project of mine is to
> implement a curses backend and I think it would be useful to take
> inspiration on another backend not using X.
>
> Regards,
>
> --
> ARJANEN Lo?c Jean David
> http://luigiscorner.wordpress.com
> ---
> "Computer science is no more about computers than astronomy is about
> telescopes, biology is about microscopes, or chemistry is about
> beakers and test tubes. Science is not about tools. It is about how we
> use them, and what we find out when we do."
> Michael R. Fellows and Ian Parberry



-- 
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA? FC7C 4086 63E3 80F2 40CF

IcedRobot: www.icedrobot.org
Proud GNU Classpath developer: http://www.classpath.org/
Read About us at: http://planet.classpath.org
OpenJDK: http://openjdk.java.net/projects/caciocavallo/

Please, support open standards:
http://endsoftpatents.org/


From roman at kennke.org  Wed Apr 11 04:06:09 2012
From: roman at kennke.org (roman at kennke.org)
Date: Wed, 11 Apr 2012 11:06:09 +0000
Subject: hg: caciocavallo/ng: Prepare pom for deploying snapshots and releases.
Message-ID: <20120411110611.6DEFF47FD9@hg.openjdk.java.net>

Changeset: 255191aa63da
Author:    rkennke
Date:      2012-04-11 13:05 +0200
URL:       http://hg.openjdk.java.net/caciocavallo/ng/rev/255191aa63da

Prepare pom for deploying snapshots and releases.

! cacio-shared/pom.xml
! cacio-tta/pom.xml
! pom.xml



From roman at kennke.org  Wed Apr 11 04:46:23 2012
From: roman at kennke.org (roman at kennke.org)
Date: Wed, 11 Apr 2012 11:46:23 +0000
Subject: hg: caciocavallo/ng: In CacioTestRunner,
	reset Toolkit and GraphicsEnvironment before/after test run.
	Consolidate CacioTestRunner and CacioFESTRunner.
Message-ID: <20120411114624.4236A47FDA@hg.openjdk.java.net>

Changeset: 0ccb01a98846
Author:    rkennke
Date:      2012-04-11 13:46 +0200
URL:       http://hg.openjdk.java.net/caciocavallo/ng/rev/0ccb01a98846

In CacioTestRunner, reset Toolkit and GraphicsEnvironment before/after test run. Consolidate CacioTestRunner and CacioFESTRunner.

! cacio-tta/src/main/java/net/java/openjdk/cacio/ctc/junit/CacioFESTRunner.java
! cacio-tta/src/main/java/net/java/openjdk/cacio/ctc/junit/CacioTestRunner.java



From roman at kennke.org  Mon Apr 16 01:17:56 2012
From: roman at kennke.org (roman at kennke.org)
Date: Mon, 16 Apr 2012 08:17:56 +0000
Subject: hg: caciocavallo/ng: Simplify CacioTestRunner: Initialize properties
	in class initializer,
	and don't attempt any reset and no messing with reflection.
Message-ID: <20120416081757.859CB470DC@hg.openjdk.java.net>

Changeset: 57c5f8ce5d1f
Author:    Roman Kennke <rkennke at redhat.com>
Date:      2012-04-16 10:17 +0200
URL:       http://hg.openjdk.java.net/caciocavallo/ng/rev/57c5f8ce5d1f

Simplify CacioTestRunner: Initialize properties in class initializer, and don't attempt any reset and no messing with reflection.

! cacio-tta/src/main/java/net/java/openjdk/cacio/ctc/junit/CacioTestRunner.java



From roman at kennke.org  Mon Apr 16 01:29:22 2012
From: roman at kennke.org (roman at kennke.org)
Date: Mon, 16 Apr 2012 08:29:22 +0000
Subject: hg: caciocavallo/ng: Implement handling of popupTrigger in EventData.
Message-ID: <20120416082922.AD513470DD@hg.openjdk.java.net>

Changeset: c02cd948b398
Author:    Roman Kennke <rkennke at redhat.com>
Date:      2012-04-16 10:20 +0200
URL:       http://hg.openjdk.java.net/caciocavallo/ng/rev/c02cd948b398

Implement handling of popupTrigger in EventData.
Contributed-by: Glen Schrader <gschrader at gmail.com>

! cacio-shared/src/main/java/sun/awt/peer/cacio/managed/EventData.java
! cacio-tta/src/main/java/net/java/openjdk/cacio/ctc/CTCRobotPeer.java
! cacio-tta/src/test/java/net/java/openjdk/cacio/ctc/SimpleFESTTest.java



From roman at kennke.org  Mon Apr 16 14:14:35 2012
From: roman at kennke.org (roman at kennke.org)
Date: Mon, 16 Apr 2012 21:14:35 +0000
Subject: hg: caciocavallo/ng: Fix focus handover between multiple windows.
Message-ID: <20120416211436.4124A470F5@hg.openjdk.java.net>

Changeset: b99ac5590c67
Author:    Roman Kennke <rkennke at redhat.com>
Date:      2012-04-16 23:13 +0200
URL:       http://hg.openjdk.java.net/caciocavallo/ng/rev/b99ac5590c67

Fix focus handover between multiple windows.
Test contributed by Glen Schrader <gschrader at gmail.com>.

! cacio-shared/src/main/java/sun/awt/peer/cacio/CacioWindowPeer.java
! cacio-shared/src/main/java/sun/awt/peer/cacio/managed/FocusManager.java
+ cacio-tta/src/test/java/net/java/openjdk/cacio/ctc/DialogFocusLostFESTTest.java



From roman at kennke.org  Mon Apr 16 14:28:42 2012
From: roman at kennke.org (Roman Kennke)
Date: Mon, 16 Apr 2012 23:28:42 +0200
Subject: latest patch
In-Reply-To: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
References: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
Message-ID: <1334611722.24772.13.camel@mercury.localdomain>

Hi Glen,

> Here is the combined patches of everything I have so far.  Sorry I
> should have been committing locally so I could have had these as
> separate patches.  If this trips you up I can repatch things in after
> you commit the other ones if you prefer, might be easier to just use
> this one though as I see my first patch was missing imports.
> 
> I still want to add a couple of test cases for what these address.
> The missing one being the mouse clicked events and the click count
> piece which was preventing being able to go into cell editing in a
> JTable.  There is still an outstanding issue around double click as
> the click count will have to increase to 2 in that case (3 for triple
> click, etc.).  I'll see if I can come up with something for that.

I committed your fix and test for the popupTrigger. I also committed
your testcase for the focus issue, however, I did not agree with your
fix (as you suspected). The real fix is to keep track of the opened
windows, and when one is closed, hand focus back to the previous one. I
also committed this. Is there anything else you have in the pipeline?
Otherwise I'd prepare a release soon (tomorrow or so).

Those latest changes have also been deployed to Cacio's snapshots maven
repository at:

https://oss.sonatype.org/content/repositories/snapshots


Also, a small hint to make our lives easier: it would be helpful to send
patches in 'hg diff --git' format (the --git is optional, but it helps
when moving, copying or renaming files). For some reason, Mercurial did
not like to hg qimport your patches, so I had to manually patch it,
figure out what is the correct --p etc. Not a big deal, but hg qimport
is just so much nicer ;-)

Cheers, Roman




From gschrader at gmail.com  Mon Apr 16 15:14:59 2012
From: gschrader at gmail.com (Glen Schrader)
Date: Mon, 16 Apr 2012 16:14:59 -0600
Subject: latest patch
In-Reply-To: <1334611722.24772.13.camel@mercury.localdomain>
References: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
	<1334611722.24772.13.camel@mercury.localdomain>
Message-ID: <BB7A42F9-A155-455D-8F32-995F3094E5BA@gmail.com>


On 2012-04-16, at 3:28 PM, Roman Kennke wrote:

> Hi Glen,
> 
> I committed your fix and test for the popupTrigger. I also committed
> your testcase for the focus issue, however, I did not agree with your
> fix (as you suspected). The real fix is to keep track of the opened
> windows, and when one is closed, hand focus back to the previous one. I
> also committed this.

Thanks for committing this, yes looking at your change that is a much better solution.

> Is there anything else you have in the pipeline?
> Otherwise I'd prepare a release soon (tomorrow or so).

Looks like the mouse click event stuff was missed.  I had the following prior to line 73 of CTCRobotPeer:

	CTCEventSource.getInstance().postEvent(mouseEvent(MouseEvent.MOUSE_CLICKED, MouseEvent.BUTTON1_DOWN_MASK, false))

I didn't have a test for that but could whip one up pretty quickly.

The only other thing I wanted to get to but haven't had a chance to look at is the click count.  I'm working around that issue right now by having this in the CTCRobotPeer.mouseEvent method: 
 
	ev.setClickCount(1);

I think this is "more right" than 0 which is what it's defaulting to right now.


> Those latest changes have also been deployed to Cacio's snapshots maven
> repository at:
> 
> https://oss.sonatype.org/content/repositories/snapshots
> 
> 
> Also, a small hint to make our lives easier: it would be helpful to send
> patches in 'hg diff --git' format (the --git is optional, but it helps
> when moving, copying or renaming files). For some reason, Mercurial did
> not like to hg qimport your patches, so I had to manually patch it,
> figure out what is the correct --p etc. Not a big deal, but hg qimport
> is just so much nicer ;-)
> 

Sure no problem, I was just being lazy and let my IDE do the patch so I was curious if it would apply ok.

Looking forward to the release!

Thanks,
Glen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/caciocavallo-dev/attachments/20120416/7697ce8c/attachment.html 

From gschrader at gmail.com  Tue Apr 17 09:17:22 2012
From: gschrader at gmail.com (Glen Schrader)
Date: Tue, 17 Apr 2012 10:17:22 -0600
Subject: latest patch
In-Reply-To: <BB7A42F9-A155-455D-8F32-995F3094E5BA@gmail.com>
References: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
	<1334611722.24772.13.camel@mercury.localdomain>
	<BB7A42F9-A155-455D-8F32-995F3094E5BA@gmail.com>
Message-ID: <CAAx7CFt85FynwOKoD9E38zoBPtfDLg1JPmGNxyBcXyiLh7pr4A@mail.gmail.com>

Here is a patch for the click event support along with test (hopefully
this patch works better!)

Thanks,
Glen

On Mon, Apr 16, 2012 at 4:14 PM, Glen Schrader <gschrader at gmail.com> wrote:
>
> On 2012-04-16, at 3:28 PM, Roman Kennke wrote:
>
> Hi Glen,
>
>
> I committed your fix and test for the popupTrigger. I also committed
> your testcase for the focus issue, however, I did not agree with your
> fix (as you suspected). The real fix is to keep track of the opened
> windows, and when one is closed, hand focus back to the previous one. I
> also committed this.
>
>
> Thanks for committing this, yes looking at your change that is a much better
> solution.
>
> Is there anything else you have in the pipeline?
> Otherwise I'd prepare a release soon (tomorrow or so).
>
>
> Looks like the mouse click event stuff was missed. ?I had the following
> prior to line 73 of?CTCRobotPeer:
>
> CTCEventSource.getInstance().postEvent(mouseEvent(MouseEvent.MOUSE_CLICKED,
> MouseEvent.BUTTON1_DOWN_MASK, false))
>
> I didn't have a test for that but could whip one up pretty quickly.
>
> The only other thing I wanted to get to but haven't had a chance to look at
> is the click count. ?I'm working around that issue right now by having this
> in the?CTCRobotPeer.mouseEvent method:
>
> ev.setClickCount(1);
>
> I think this is "more right" than 0 which is what it's defaulting to right
> now.
>
>
> Those latest changes have also been deployed to Cacio's snapshots maven
> repository at:
>
> https://oss.sonatype.org/content/repositories/snapshots
>
>
> Also, a small hint to make our lives easier: it would be helpful to send
> patches in 'hg diff --git' format (the --git is optional, but it helps
> when moving, copying or renaming files). For some reason, Mercurial did
> not like to hg qimport your patches, so I had to manually patch it,
> figure out what is the correct --p etc. Not a big deal, but hg qimport
> is just so much nicer ;-)
>
>
> Sure no problem, I was just being lazy and let my IDE do the patch so I was
> curious if it would apply ok.
>
> Looking forward to the release!
>
> Thanks,
> Glen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clickevent.patch
Type: application/octet-stream
Size: 5120 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/caciocavallo-dev/attachments/20120417/e47c89ba/clickevent.patch 

From roman at kennke.org  Wed Apr 18 05:41:26 2012
From: roman at kennke.org (Roman Kennke)
Date: Wed, 18 Apr 2012 14:41:26 +0200
Subject: latest patch
In-Reply-To: <CAAx7CFt85FynwOKoD9E38zoBPtfDLg1JPmGNxyBcXyiLh7pr4A@mail.gmail.com>
References: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
	<1334611722.24772.13.camel@mercury.localdomain>
	<BB7A42F9-A155-455D-8F32-995F3094E5BA@gmail.com>
	<CAAx7CFt85FynwOKoD9E38zoBPtfDLg1JPmGNxyBcXyiLh7pr4A@mail.gmail.com>
Message-ID: <1334752886.27302.3.camel@mercury.localdomain>

Hi Glen,

Am Dienstag, den 17.04.2012, 10:17 -0600 schrieb Glen Schrader:
> Here is a patch for the click event support along with test (hopefully
> this patch works better!)

Thanks for all your efforts!

I took your testcase, added some tests and improved the implementation.
It now supports the following:

- Multi-click (double-click).
- Click event in correct order (after release event).
- Press and release also receive correct click count.
- When press and release are on different location -> no click.

I'll commit the attached patch shortly.

Please let me know if you would like to see anything else before the
release!

Again: thanks for your efforts!

Cheers,
Roman


-------------- next part --------------
A non-text attachment was scrubbed...
Name: clickevent.patch
Type: text/x-patch
Size: 12163 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/caciocavallo-dev/attachments/20120418/f3a452a1/clickevent.patch 

From roman at kennke.org  Wed Apr 18 05:41:52 2012
From: roman at kennke.org (roman at kennke.org)
Date: Wed, 18 Apr 2012 12:41:52 +0000
Subject: hg: caciocavallo/ng: Implement mouse click and multi-click support.
Message-ID: <20120418124153.1F02E47145@hg.openjdk.java.net>

Changeset: fef83498c1e0
Author:    Roman Kennke <rkennke at redhat.com>
Date:      2012-04-18 14:39 +0200
URL:       http://hg.openjdk.java.net/caciocavallo/ng/rev/fef83498c1e0

Implement mouse click and multi-click support.
Original testcase contributed by Glen Schrader <gschrader at gmail.com>.

! cacio-tta/src/main/java/net/java/openjdk/cacio/ctc/CTCRobotPeer.java
+ cacio-tta/src/test/java/net/java/openjdk/cacio/ctc/ClickEventTestFESTTest.java



From gschrader at gmail.com  Wed Apr 18 08:13:38 2012
From: gschrader at gmail.com (Glen Schrader)
Date: Wed, 18 Apr 2012 09:13:38 -0600
Subject: latest patch
In-Reply-To: <1334752886.27302.3.camel@mercury.localdomain>
References: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
	<1334611722.24772.13.camel@mercury.localdomain>
	<BB7A42F9-A155-455D-8F32-995F3094E5BA@gmail.com>
	<CAAx7CFt85FynwOKoD9E38zoBPtfDLg1JPmGNxyBcXyiLh7pr4A@mail.gmail.com>
	<1334752886.27302.3.camel@mercury.localdomain>
Message-ID: <CAAx7CFvMRitVUm--mEeT1MgJPW9cODVE_inyAMVJmP1nft-+Yg@mail.gmail.com>

Thanks for finishing what I had!  I think you missed adding
MouseClickSupport in your commit though.


On Wed, Apr 18, 2012 at 6:41 AM, Roman Kennke <roman at kennke.org> wrote:
> Hi Glen,
>
> Am Dienstag, den 17.04.2012, 10:17 -0600 schrieb Glen Schrader:
>> Here is a patch for the click event support along with test (hopefully
>> this patch works better!)
>
> Thanks for all your efforts!
>
> I took your testcase, added some tests and improved the implementation.
> It now supports the following:
>
> - Multi-click (double-click).
> - Click event in correct order (after release event).
> - Press and release also receive correct click count.
> - When press and release are on different location -> no click.
>
> I'll commit the attached patch shortly.
>
> Please let me know if you would like to see anything else before the
> release!
>
> Again: thanks for your efforts!
>
> Cheers,
> Roman
>
>


From roman at kennke.org  Wed Apr 18 08:16:03 2012
From: roman at kennke.org (roman at kennke.org)
Date: Wed, 18 Apr 2012 15:16:03 +0000
Subject: hg: caciocavallo/ng: Implement mouse click and multi-click support
	(forgot new class in last commit).
Message-ID: <20120418151604.C710C47148@hg.openjdk.java.net>

Changeset: 0d804575dc7d
Author:    Roman Kennke <rkennke at redhat.com>
Date:      2012-04-18 17:15 +0200
URL:       http://hg.openjdk.java.net/caciocavallo/ng/rev/0d804575dc7d

Implement mouse click and multi-click support (forgot new class in last commit).

+ cacio-tta/src/main/java/net/java/openjdk/cacio/ctc/MouseClickSupport.java



From roman at kennke.org  Wed Apr 18 08:16:20 2012
From: roman at kennke.org (Roman Kennke)
Date: Wed, 18 Apr 2012 17:16:20 +0200
Subject: latest patch
In-Reply-To: <CAAx7CFvMRitVUm--mEeT1MgJPW9cODVE_inyAMVJmP1nft-+Yg@mail.gmail.com>
References: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
	<1334611722.24772.13.camel@mercury.localdomain>
	<BB7A42F9-A155-455D-8F32-995F3094E5BA@gmail.com>
	<CAAx7CFt85FynwOKoD9E38zoBPtfDLg1JPmGNxyBcXyiLh7pr4A@mail.gmail.com>
	<1334752886.27302.3.camel@mercury.localdomain>
	<CAAx7CFvMRitVUm--mEeT1MgJPW9cODVE_inyAMVJmP1nft-+Yg@mail.gmail.com>
Message-ID: <1334762180.27302.7.camel@mercury.localdomain>

> Thanks for finishing what I had!  I think you missed adding
> MouseClickSupport in your commit though.

Damn! Fixed now...

Thanks,
Roman


> 
> On Wed, Apr 18, 2012 at 6:41 AM, Roman Kennke <roman at kennke.org> wrote:
> > Hi Glen,
> >
> > Am Dienstag, den 17.04.2012, 10:17 -0600 schrieb Glen Schrader:
> >> Here is a patch for the click event support along with test (hopefully
> >> this patch works better!)
> >
> > Thanks for all your efforts!
> >
> > I took your testcase, added some tests and improved the implementation.
> > It now supports the following:
> >
> > - Multi-click (double-click).
> > - Click event in correct order (after release event).
> > - Press and release also receive correct click count.
> > - When press and release are on different location -> no click.
> >
> > I'll commit the attached patch shortly.
> >
> > Please let me know if you would like to see anything else before the
> > release!
> >
> > Again: thanks for your efforts!
> >
> > Cheers,
> > Roman
> >
> >
> 




From gschrader at gmail.com  Wed Apr 18 09:19:40 2012
From: gschrader at gmail.com (Glen Schrader)
Date: Wed, 18 Apr 2012 10:19:40 -0600
Subject: latest patch
In-Reply-To: <1334762180.27302.7.camel@mercury.localdomain>
References: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
	<1334611722.24772.13.camel@mercury.localdomain>
	<BB7A42F9-A155-455D-8F32-995F3094E5BA@gmail.com>
	<CAAx7CFt85FynwOKoD9E38zoBPtfDLg1JPmGNxyBcXyiLh7pr4A@mail.gmail.com>
	<1334752886.27302.3.camel@mercury.localdomain>
	<CAAx7CFvMRitVUm--mEeT1MgJPW9cODVE_inyAMVJmP1nft-+Yg@mail.gmail.com>
	<1334762180.27302.7.camel@mercury.localdomain>
Message-ID: <CAAx7CFumEvpXk5RgOhbE0Eb6YQmsPin2ixf+1qRpm6335fq-rQ@mail.gmail.com>

Thanks!  Just out of curiosity I ran ClickEventTestFESTTest without
the cacio runner, the tests pass on Windows but the last 3 tests in
fail on Mac.  The Mac still considers it a mouse click when you move
the mouse a pixel, I'm kind of baffled on what's going on in the last
2, no events are added to the list in those.  This won't impact me
though so I'm not going to worry about it.

I have nothing else at the moment for the release.

Cheers,
Glen


On Wed, Apr 18, 2012 at 9:16 AM, Roman Kennke <roman at kennke.org> wrote:
>> Thanks for finishing what I had! ?I think you missed adding
>> MouseClickSupport in your commit though.
>
> Damn! Fixed now...
>
> Thanks,
> Roman
>
>
>>
>> On Wed, Apr 18, 2012 at 6:41 AM, Roman Kennke <roman at kennke.org> wrote:
>> > Hi Glen,
>> >
>> > Am Dienstag, den 17.04.2012, 10:17 -0600 schrieb Glen Schrader:
>> >> Here is a patch for the click event support along with test (hopefully
>> >> this patch works better!)
>> >
>> > Thanks for all your efforts!
>> >
>> > I took your testcase, added some tests and improved the implementation.
>> > It now supports the following:
>> >
>> > - Multi-click (double-click).
>> > - Click event in correct order (after release event).
>> > - Press and release also receive correct click count.
>> > - When press and release are on different location -> no click.
>> >
>> > I'll commit the attached patch shortly.
>> >
>> > Please let me know if you would like to see anything else before the
>> > release!
>> >
>> > Again: thanks for your efforts!
>> >
>> > Cheers,
>> > Roman
>> >
>> >
>>
>
>


From gschrader at gmail.com  Wed Apr 18 20:33:23 2012
From: gschrader at gmail.com (Glen Schrader)
Date: Wed, 18 Apr 2012 21:33:23 -0600
Subject: latest patch
In-Reply-To: <CAAx7CFumEvpXk5RgOhbE0Eb6YQmsPin2ixf+1qRpm6335fq-rQ@mail.gmail.com>
References: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
	<1334611722.24772.13.camel@mercury.localdomain>
	<BB7A42F9-A155-455D-8F32-995F3094E5BA@gmail.com>
	<CAAx7CFt85FynwOKoD9E38zoBPtfDLg1JPmGNxyBcXyiLh7pr4A@mail.gmail.com>
	<1334752886.27302.3.camel@mercury.localdomain>
	<CAAx7CFvMRitVUm--mEeT1MgJPW9cODVE_inyAMVJmP1nft-+Yg@mail.gmail.com>
	<1334762180.27302.7.camel@mercury.localdomain>
	<CAAx7CFumEvpXk5RgOhbE0Eb6YQmsPin2ixf+1qRpm6335fq-rQ@mail.gmail.com>
Message-ID: <CAAx7CFtP-wjergy4v+AXgCR5u0+774WwUyozuDK55vaLoPZBYg@mail.gmail.com>

Hi there, I've found a regression which is causing me some grief with
the popup boolean again.  I believe it should only be true for right
click on mouse release (in Windows anyway).  I've attached a patch
with test.

Thanks,
Glen

On Wed, Apr 18, 2012 at 10:19 AM, Glen Schrader <gschrader at gmail.com> wrote:
> Thanks! ?Just out of curiosity I ran ClickEventTestFESTTest without
> the cacio runner, the tests pass on Windows but the last 3 tests in
> fail on Mac. ?The Mac still considers it a mouse click when you move
> the mouse a pixel, I'm kind of baffled on what's going on in the last
> 2, no events are added to the list in those. ?This won't impact me
> though so I'm not going to worry about it.
>
> I have nothing else at the moment for the release.
>
> Cheers,
> Glen
>
>
> On Wed, Apr 18, 2012 at 9:16 AM, Roman Kennke <roman at kennke.org> wrote:
>>> Thanks for finishing what I had! ?I think you missed adding
>>> MouseClickSupport in your commit though.
>>
>> Damn! Fixed now...
>>
>> Thanks,
>> Roman
>>
>>
>>>
>>> On Wed, Apr 18, 2012 at 6:41 AM, Roman Kennke <roman at kennke.org> wrote:
>>> > Hi Glen,
>>> >
>>> > Am Dienstag, den 17.04.2012, 10:17 -0600 schrieb Glen Schrader:
>>> >> Here is a patch for the click event support along with test (hopefully
>>> >> this patch works better!)
>>> >
>>> > Thanks for all your efforts!
>>> >
>>> > I took your testcase, added some tests and improved the implementation.
>>> > It now supports the following:
>>> >
>>> > - Multi-click (double-click).
>>> > - Click event in correct order (after release event).
>>> > - Press and release also receive correct click count.
>>> > - When press and release are on different location -> no click.
>>> >
>>> > I'll commit the attached patch shortly.
>>> >
>>> > Please let me know if you would like to see anything else before the
>>> > release!
>>> >
>>> > Again: thanks for your efforts!
>>> >
>>> > Cheers,
>>> > Roman
>>> >
>>> >
>>>
>>
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: popup_regression.patch
Type: application/octet-stream
Size: 3890 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/caciocavallo-dev/attachments/20120418/fd5487e3/popup_regression.patch 

From roman at kennke.org  Mon Apr 23 03:19:02 2012
From: roman at kennke.org (Roman Kennke)
Date: Mon, 23 Apr 2012 12:19:02 +0200
Subject: latest patch
In-Reply-To: <CAAx7CFtP-wjergy4v+AXgCR5u0+774WwUyozuDK55vaLoPZBYg@mail.gmail.com>
References: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
	<1334611722.24772.13.camel@mercury.localdomain>
	<BB7A42F9-A155-455D-8F32-995F3094E5BA@gmail.com>
	<CAAx7CFt85FynwOKoD9E38zoBPtfDLg1JPmGNxyBcXyiLh7pr4A@mail.gmail.com>
	<1334752886.27302.3.camel@mercury.localdomain>
	<CAAx7CFvMRitVUm--mEeT1MgJPW9cODVE_inyAMVJmP1nft-+Yg@mail.gmail.com>
	<1334762180.27302.7.camel@mercury.localdomain>
	<CAAx7CFumEvpXk5RgOhbE0Eb6YQmsPin2ixf+1qRpm6335fq-rQ@mail.gmail.com>
	<CAAx7CFtP-wjergy4v+AXgCR5u0+774WwUyozuDK55vaLoPZBYg@mail.gmail.com>
Message-ID: <1335176342.21255.29.camel@mercury.localdomain>

Hi Glen,

Sorry for the late reply. The change seems reasonable, I will commit it
in a bit.

Regarding the platform differences: it appears that the behavior of some
of the things that we do here is dependend on the platform. For example,
when I run your popup-trigger test on Linux, I get a popup trigger on
MOUSE_PRESSED (and yes, when I rightclick somewhere, popups appears on
pressing, not on releasing the mouse). You observed a similar difference
earlier regarding the mouse-clicking emulation. I see that as a good
thing: it gives us some freedoms to implement these things. I think in
the long run we have the following options:

- Implement whatever we think is correct. This will result in a
hodgepodge of little behavioural differences, i.e. some things will
behave like on Windows, some like on Linux, some like on the Mac
(because the patches contributed come from people on those platforms).
This is not necessarily a bad thing, applications should not depend on
those differences. This is what we have now.
- We decide for one platform and try to emulate behaviour of this. For
example, we could decide that Windows is our reference (ugh).
- We introduce a little abstraction layer and make the exact behaviour
configurable, i.e. decide by a system property which emulation to use.

The last option would clearly be the coolest, but require most work, the
first one we already have, the 2nd one will probably never happen (which
platform to choose?).

After the patch is in, can you give it a little more testing and send me
a notice when you think it's fine for a release?

Cheers,
Roman

> Hi there, I've found a regression which is causing me some grief with
> the popup boolean again.  I believe it should only be true for right
> click on mouse release (in Windows anyway).  I've attached a patch
> with test.
> 
> Thanks,
> Glen
> 
> On Wed, Apr 18, 2012 at 10:19 AM, Glen Schrader <gschrader at gmail.com> wrote:
> > Thanks!  Just out of curiosity I ran ClickEventTestFESTTest without
> > the cacio runner, the tests pass on Windows but the last 3 tests in
> > fail on Mac.  The Mac still considers it a mouse click when you move
> > the mouse a pixel, I'm kind of baffled on what's going on in the last
> > 2, no events are added to the list in those.  This won't impact me
> > though so I'm not going to worry about it.
> >
> > I have nothing else at the moment for the release.
> >
> > Cheers,
> > Glen
> >
> >
> > On Wed, Apr 18, 2012 at 9:16 AM, Roman Kennke <roman at kennke.org> wrote:
> >>> Thanks for finishing what I had!  I think you missed adding
> >>> MouseClickSupport in your commit though.
> >>
> >> Damn! Fixed now...
> >>
> >> Thanks,
> >> Roman
> >>
> >>
> >>>
> >>> On Wed, Apr 18, 2012 at 6:41 AM, Roman Kennke <roman at kennke.org> wrote:
> >>> > Hi Glen,
> >>> >
> >>> > Am Dienstag, den 17.04.2012, 10:17 -0600 schrieb Glen Schrader:
> >>> >> Here is a patch for the click event support along with test (hopefully
> >>> >> this patch works better!)
> >>> >
> >>> > Thanks for all your efforts!
> >>> >
> >>> > I took your testcase, added some tests and improved the implementation.
> >>> > It now supports the following:
> >>> >
> >>> > - Multi-click (double-click).
> >>> > - Click event in correct order (after release event).
> >>> > - Press and release also receive correct click count.
> >>> > - When press and release are on different location -> no click.
> >>> >
> >>> > I'll commit the attached patch shortly.
> >>> >
> >>> > Please let me know if you would like to see anything else before the
> >>> > release!
> >>> >
> >>> > Again: thanks for your efforts!
> >>> >
> >>> > Cheers,
> >>> > Roman
> >>> >
> >>> >
> >>>
> >>
> >>




From roman at kennke.org  Mon Apr 23 03:20:54 2012
From: roman at kennke.org (roman at kennke.org)
Date: Mon, 23 Apr 2012 10:20:54 +0000
Subject: hg: caciocavallo/ng: Fix popup-trigger to only be set on right mouse
	button and mouse-release.
Message-ID: <20120423102056.5AE0F47212@hg.openjdk.java.net>

Changeset: 871553ec7777
Author:    Roman Kennke <rkennke at redhat.com>
Date:      2012-04-23 12:20 +0200
URL:       http://hg.openjdk.java.net/caciocavallo/ng/rev/871553ec7777

Fix popup-trigger to only be set on right mouse button and mouse-release.
Contributed-by: Glen Schrader <gschrader at gmail.com>

! cacio-tta/src/main/java/net/java/openjdk/cacio/ctc/CTCRobotPeer.java
! cacio-tta/src/main/java/net/java/openjdk/cacio/ctc/MouseClickSupport.java
! cacio-tta/src/test/java/net/java/openjdk/cacio/ctc/ClickEventTestFESTTest.java



From gschrader at gmail.com  Tue Apr 24 09:27:04 2012
From: gschrader at gmail.com (Glen Schrader)
Date: Tue, 24 Apr 2012 10:27:04 -0600
Subject: latest patch
In-Reply-To: <1335176342.21255.29.camel@mercury.localdomain>
References: <CAAx7CFufnKaXk2FS98HRFtmXnZK-s4NrJj65qHVgCCS9y5XAEQ@mail.gmail.com>
	<1334611722.24772.13.camel@mercury.localdomain>
	<BB7A42F9-A155-455D-8F32-995F3094E5BA@gmail.com>
	<CAAx7CFt85FynwOKoD9E38zoBPtfDLg1JPmGNxyBcXyiLh7pr4A@mail.gmail.com>
	<1334752886.27302.3.camel@mercury.localdomain>
	<CAAx7CFvMRitVUm--mEeT1MgJPW9cODVE_inyAMVJmP1nft-+Yg@mail.gmail.com>
	<1334762180.27302.7.camel@mercury.localdomain>
	<CAAx7CFumEvpXk5RgOhbE0Eb6YQmsPin2ixf+1qRpm6335fq-rQ@mail.gmail.com>
	<CAAx7CFtP-wjergy4v+AXgCR5u0+774WwUyozuDK55vaLoPZBYg@mail.gmail.com>
	<1335176342.21255.29.camel@mercury.localdomain>
Message-ID: <CAAx7CFssk9NO36FhQKhzD0_wOGBERVOtrfiarD_y7rM7wn-8eA@mail.gmail.com>

Hi Roman,

I believe it's good for the release, I haven't encountered any issues
related to mouse events in our test suite.

I agree with you in terms of the platform differences, option 3 might
be nice to have but I don't see it being a huge deal since most Swing
apps aren't going to be coded that closely to the event differences.
Just need to be aware sometimes of the differences.

Cheers,
Glen

On Mon, Apr 23, 2012 at 4:19 AM, Roman Kennke <roman at kennke.org> wrote:
> Hi Glen,
>
> Sorry for the late reply. The change seems reasonable, I will commit it
> in a bit.
>
> Regarding the platform differences: it appears that the behavior of some
> of the things that we do here is dependend on the platform. For example,
> when I run your popup-trigger test on Linux, I get a popup trigger on
> MOUSE_PRESSED (and yes, when I rightclick somewhere, popups appears on
> pressing, not on releasing the mouse). You observed a similar difference
> earlier regarding the mouse-clicking emulation. I see that as a good
> thing: it gives us some freedoms to implement these things. I think in
> the long run we have the following options:
>
> - Implement whatever we think is correct. This will result in a
> hodgepodge of little behavioural differences, i.e. some things will
> behave like on Windows, some like on Linux, some like on the Mac
> (because the patches contributed come from people on those platforms).
> This is not necessarily a bad thing, applications should not depend on
> those differences. This is what we have now.
> - We decide for one platform and try to emulate behaviour of this. For
> example, we could decide that Windows is our reference (ugh).
> - We introduce a little abstraction layer and make the exact behaviour
> configurable, i.e. decide by a system property which emulation to use.
>
> The last option would clearly be the coolest, but require most work, the
> first one we already have, the 2nd one will probably never happen (which
> platform to choose?).
>
> After the patch is in, can you give it a little more testing and send me
> a notice when you think it's fine for a release?
>
> Cheers,
> Roman
>
>> Hi there, I've found a regression which is causing me some grief with
>> the popup boolean again. ?I believe it should only be true for right
>> click on mouse release (in Windows anyway). ?I've attached a patch
>> with test.
>>
>> Thanks,
>> Glen
>>
>> On Wed, Apr 18, 2012 at 10:19 AM, Glen Schrader <gschrader at gmail.com> wrote:
>> > Thanks! ?Just out of curiosity I ran ClickEventTestFESTTest without
>> > the cacio runner, the tests pass on Windows but the last 3 tests in
>> > fail on Mac. ?The Mac still considers it a mouse click when you move
>> > the mouse a pixel, I'm kind of baffled on what's going on in the last
>> > 2, no events are added to the list in those. ?This won't impact me
>> > though so I'm not going to worry about it.
>> >
>> > I have nothing else at the moment for the release.
>> >
>> > Cheers,
>> > Glen
>> >
>> >
>> > On Wed, Apr 18, 2012 at 9:16 AM, Roman Kennke <roman at kennke.org> wrote:
>> >>> Thanks for finishing what I had! ?I think you missed adding
>> >>> MouseClickSupport in your commit though.
>> >>
>> >> Damn! Fixed now...
>> >>
>> >> Thanks,
>> >> Roman
>> >>
>> >>
>> >>>
>> >>> On Wed, Apr 18, 2012 at 6:41 AM, Roman Kennke <roman at kennke.org> wrote:
>> >>> > Hi Glen,
>> >>> >
>> >>> > Am Dienstag, den 17.04.2012, 10:17 -0600 schrieb Glen Schrader:
>> >>> >> Here is a patch for the click event support along with test (hopefully
>> >>> >> this patch works better!)
>> >>> >
>> >>> > Thanks for all your efforts!
>> >>> >
>> >>> > I took your testcase, added some tests and improved the implementation.
>> >>> > It now supports the following:
>> >>> >
>> >>> > - Multi-click (double-click).
>> >>> > - Click event in correct order (after release event).
>> >>> > - Press and release also receive correct click count.
>> >>> > - When press and release are on different location -> no click.
>> >>> >
>> >>> > I'll commit the attached patch shortly.
>> >>> >
>> >>> > Please let me know if you would like to see anything else before the
>> >>> > release!
>> >>> >
>> >>> > Again: thanks for your efforts!
>> >>> >
>> >>> > Cheers,
>> >>> > Roman
>> >>> >
>> >>> >
>> >>>
>> >>
>> >>
>
>