latest patch

[Glen Schrader]

Hi there, I've found a regression which is causing me some grief with
the popup boolean again.  I believe it should only be true for right
click on mouse release (in Windows anyway).  I've attached a patch
with test.

Thanks,
Glen

On Wed, Apr 18, 2012 at 10:19 AM, Glen Schrader <gschrader at gmail.com> wrote:
> Thanks!  Just out of curiosity I ran ClickEventTestFESTTest without
> the cacio runner, the tests pass on Windows but the last 3 tests in
> fail on Mac.  The Mac still considers it a mouse click when you move
> the mouse a pixel, I'm kind of baffled on what's going on in the last
> 2, no events are added to the list in those.  This won't impact me
> though so I'm not going to worry about it.
>
> I have nothing else at the moment for the release.
>
> Cheers,
> Glen
>
>
> On Wed, Apr 18, 2012 at 9:16 AM, Roman Kennke <roman at kennke.org> wrote:
>>> Thanks for finishing what I had!  I think you missed adding
>>> MouseClickSupport in your commit though.
>>
>> Damn! Fixed now...
>>
>> Thanks,
>> Roman
>>
>>
>>>
>>> On Wed, Apr 18, 2012 at 6:41 AM, Roman Kennke <roman at kennke.org> wrote:
>>> > Hi Glen,
>>> >
>>> > Am Dienstag, den 17.04.2012, 10:17 -0600 schrieb Glen Schrader:
>>> >> Here is a patch for the click event support along with test (hopefully
>>> >> this patch works better!)
>>> >
>>> > Thanks for all your efforts!
>>> >
>>> > I took your testcase, added some tests and improved the implementation.
>>> > It now supports the following:
>>> >
>>> > - Multi-click (double-click).
>>> > - Click event in correct order (after release event).
>>> > - Press and release also receive correct click count.
>>> > - When press and release are on different location -> no click.
>>> >
>>> > I'll commit the attached patch shortly.
>>> >
>>> > Please let me know if you would like to see anything else before the
>>> > release!
>>> >
>>> > Again: thanks for your efforts!
>>> >
>>> > Cheers,
>>> > Roman
>>> >
>>> >
>>>
>>
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: popup_regression.patch
Type: application/octet-stream
Size: 3890 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/caciocavallo-dev/attachments/20120418/fd5487e3/popup_regression.patch