From adam.sotona at oracle.com Thu Feb 1 09:42:09 2024 From: adam.sotona at oracle.com (Adam Sotona) Date: Thu, 1 Feb 2024 09:42:09 +0000 Subject: JEP Draft: Class-File API (Second Preview) In-Reply-To: <23C8DC69-97C6-4A40-87FD-A0791CFA1879@oracle.com> References: <23C8DC69-97C6-4A40-87FD-A0791CFA1879@oracle.com> Message-ID: From: Paul Sandoz AFAICT the only substantial change to the text is the addition of the history section? Yes, added history and minor snippets adjustments according to the CodeBuilder (proposed) changes. Class-File API was proposed as a preview feature by JEP 457 and delivered in JDK 22 . -> The Class-File API... Fixed, thanks. I think it would be useful to be a little more descriptive on the changes > - CodeBuilder API surface consolidation I am guessing this is removing redundant method, or vestiges from early designs, from the builder and using a more consistent pattern for method names and signatures? Yes, I?ll describe it more precisely, thanks. BTW it is still in progress: https://bugs.openjdk.org/browse/JDK-8323058 - Small API adjustments to better match JVM Specification -> - Minor API updates for improved alignment with the JVM specification. e.g., ? Fixed, thanks. Implementation-wise were there any performance improvements? Or improvements to the validation of class files? Yes, performance improvements (with specific conversion use cases in mind) are continuous process. I would have to investigate the log which performance improvements already fell into 22. ClassModel::verify implementation is planned to include extended class validation (in progress: https://bugs.openjdk.org/browse/JDK-8320396). Thanks, Adam -------------- next part -------------- An HTML attachment was scrubbed... URL: From liangchenblue at gmail.com Mon Feb 12 22:42:22 2024 From: liangchenblue at gmail.com (-) Date: Mon, 12 Feb 2024 16:42:22 -0600 Subject: [meta] How to benchmark reliably? Message-ID: Hi, To ensure the Class-File API stays efficient, we often run benchmarks and check its results. However, I frequently get perturbations in my results on Windows: it seems that background applications or browsers can potentially slow down Java benchmarks, making the results unreliable between branch checkouts. What's the environments on which you run benchmarks? I just wish to find one that would be free from outside influences. Is WSL2 (building for Linux) a good alternative, or is my best luck on some other rented machines/dedicated CIs? Chen Liang -------------- next part -------------- An HTML attachment was scrubbed... URL: