From adam.sotona at oracle.com  Mon Sep  2 08:43:59 2024
From: adam.sotona at oracle.com (Adam Sotona)
Date: Mon, 2 Sep 2024 08:43:59 +0000
Subject: Switch targets are not inflated in CodeModel if no StackMap.
In-Reply-To: <3b879ddf.278d8.191a74c728c.Webtop.250@btinternet.com>
References: <3b879ddf.278d8.191a74c728c.Webtop.250@btinternet.com>
Message-ID: <DS0PR10MB68472611942BAD38A91AEC928C922@DS0PR10MB6847.namprd10.prod.outlook.com>

Yes, this is a bug in labels inflation for older class files versions.
I?ve filled a bug https://bugs.openjdk.org/browse/JDK-8339368 based on your test case and started work on a fix.

Thank you for discovering it!

From: classfile-api-dev <classfile-api-dev-retn at openjdk.org> on behalf of david32768 at btinternet.com <david32768 at btinternet.com>
Date: Saturday, 31 August 2024 at 9:18
To: classfile-api-dev at openjdk.org <classfile-api-dev at openjdk.org>
Subject: Switch targets are not inflated in CodeModel if no StackMap.

Method jdk/internal/CodeImpl.inflateJumpTargets should also inflate switch instructions.



Perhaps BranchInstruction, JsrInstruction, TableSwitchInstruction, LookupSwitchInstruction should implement an interface with method List<Label> targets().



build test method
```
   private static void build(CodeBuilder cob) {
       Label L1 = cob.newLabel();
       Label L2 = cob.newLabel();
       SwitchCase sc1 = SwitchCase.of(0,L2);
       List<SwitchCase> cases = new ArrayList<>();
       cases.add(sc1);
       cob.iload(0)
          .lookupswitch(L1, cases)
          .labelBinding(L2)
          .iconst_1()
          .ireturn()
          .labelBinding(L1)
          .iconst_0()
          .ireturn();
   }

```

print of elements in CodeModel
```
Load[OP=ILOAD_0, slot=0]
LookupSwitch[OP=LOOKUPSWITCH]
UnboundIntrinsicConstantInstruction[op=ICONST_1]
Return[OP=IRETURN]
UnboundIntrinsicConstantInstruction[op=ICONST_0]
Return[OP=IRETURN]

```

test driver class
```
   public static void main(String[] args) throws IOException {
       byte[] bytes = ClassFile.of()
               .build(ClassDesc.of("TestSwitchInflate"),
                     clb -> clb.withFlags(ClassFile.ACC_PUBLIC  | ClassFile.ACC_SUPER)
               .withVersion(49,0)
               .withMethodBody("Table", MethodTypeDesc.ofDescriptor("(I)I"),
                    ClassFile.ACC_STATIC, SwitchInflate::build));
       ClassFile.of().parse(bytes)
           .methods().stream()
                .flatMap(m -> m.code().stream())
               .flatMap(c -> c.elementStream())
               .forEach(System.out::println);
   }

```

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/classfile-api-dev/attachments/20240902/182c8ea6/attachment-0001.htm>

From o.myhre at gmail.com  Tue Sep 17 09:00:06 2024
From: o.myhre at gmail.com (=?UTF-8?Q?=C3=98ystein_Myhre_Andersen?=)
Date: Tue, 17 Sep 2024 11:00:06 +0200
Subject: NoSuchMethodError: instanceOf
Message-ID: <CAKV_CfX=_hUOZfntAVZm4=9mjqgqv-Y-Ep_ZQovR+Qa=Y0JC3g@mail.gmail.com>

I am trying to use JDK 23 Release-Candidate Build 37.
The instanceof_ method has been replaced with instanceOf.

But at runtime i got: java.lang.NoSuchMethodError:
'java.lang.classfile.CodeBuilder
java.lang.classfile.CodeBuilder.instanceOf(java.lang.constant.ClassDesc)'

Javadoc says:
default CodeBuilder
<https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/CodeBuilder.html>
PREVIEW
<https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/CodeBuilder.html#preview-java.lang.classfile.CodeBuilder>
instanceOf
<https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/CodeBuilder.html#instanceOf(java.lang.constant.ClassDesc)>
(ClassDesc
<https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/constant/ClassDesc.html>
 target)
Generate an instruction to determine if an object is of the given type

- ?ystein Myhre Andersen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/classfile-api-dev/attachments/20240917/61968c97/attachment.htm>

From adam.sotona at oracle.com  Tue Sep 17 09:20:55 2024
From: adam.sotona at oracle.com (Adam Sotona)
Date: Tue, 17 Sep 2024 09:20:55 +0000
Subject: NoSuchMethodError: instanceOf
In-Reply-To: <CAKV_CfX=_hUOZfntAVZm4=9mjqgqv-Y-Ep_ZQovR+Qa=Y0JC3g@mail.gmail.com>
References: <CAKV_CfX=_hUOZfntAVZm4=9mjqgqv-Y-Ep_ZQovR+Qa=Y0JC3g@mail.gmail.com>
Message-ID: <DS0PR10MB684733F9C1847B1C0611C7898C612@DS0PR10MB6847.namprd10.prod.outlook.com>

I?ve just tried to reproduce it and JDK 23 Release-Candidate Build 37 works with java.lang.classfile.CodeBuilder.instanceOf(java.lang.constant.ClassDesc) for me (compilation + execution and in source launcher).

Adam


From: classfile-api-dev <classfile-api-dev-retn at openjdk.org> on behalf of ?ystein Myhre Andersen <o.myhre at gmail.com>
Date: Tuesday, 17 September 2024 at 11:00
To: classfile-api-dev <classfile-api-dev at openjdk.org>
Subject: NoSuchMethodError: instanceOf
I am trying to use JDK 23 Release-Candidate Build 37.
The instanceof_ method has been replaced with instanceOf.

But at runtime i got: java.lang.NoSuchMethodError: 'java.lang.classfile.CodeBuilder java.lang.classfile.CodeBuilder.instanceOf(java.lang.constant.ClassDesc)'

Javadoc says:
default CodeBuilder<https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/CodeBuilder.html>PREVIEW<https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/CodeBuilder.html#preview-java.lang.classfile.CodeBuilder>
instanceOf<https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/CodeBuilder.html#instanceOf(java.lang.constant.ClassDesc)>(ClassDesc<https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/constant/ClassDesc.html> target)
Generate an instruction to determine if an object is of the given type

- ?ystein Myhre Andersen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/classfile-api-dev/attachments/20240917/ecbd88b0/attachment.htm>

From o.myhre at gmail.com  Tue Sep 17 09:31:35 2024
From: o.myhre at gmail.com (=?UTF-8?Q?=C3=98ystein_Myhre_Andersen?=)
Date: Tue, 17 Sep 2024 11:31:35 +0200
Subject: NoSuchMethodError: instanceOf
In-Reply-To: <DS0PR10MB684733F9C1847B1C0611C7898C612@DS0PR10MB6847.namprd10.prod.outlook.com>
References: <CAKV_CfX=_hUOZfntAVZm4=9mjqgqv-Y-Ep_ZQovR+Qa=Y0JC3g@mail.gmail.com>
 <DS0PR10MB684733F9C1847B1C0611C7898C612@DS0PR10MB6847.namprd10.prod.outlook.com>
Message-ID: <CAKV_CfWc-RH6pwVyYttuXJt5nOmvWfTzrt7qXY2bbqk7JFCJBQ@mail.gmail.com>

Fixed!

I have several Eclipse projects that use each other. Hadn't updated all to
jdk-23. Thanks !

On Tue, Sep 17, 2024 at 11:20?AM Adam Sotona <adam.sotona at oracle.com> wrote:

> I?ve just tried to reproduce it and JDK 23 Release-Candidate Build 37
> works with
> java.lang.classfile.CodeBuilder.instanceOf(java.lang.constant.ClassDesc)
> for me (compilation + execution and in source launcher).
>
>
>
> Adam
>
>
>
>
>
> *From: *classfile-api-dev <classfile-api-dev-retn at openjdk.org> on behalf
> of ?ystein Myhre Andersen <o.myhre at gmail.com>
> *Date: *Tuesday, 17 September 2024 at 11:00
> *To: *classfile-api-dev <classfile-api-dev at openjdk.org>
> *Subject: *NoSuchMethodError: instanceOf
>
> I am trying to use JDK 23 Release-Candidate Build 37.
>
> The instanceof_ method has been replaced with instanceOf.
>
>
> But at runtime i got: java.lang.NoSuchMethodError:
> 'java.lang.classfile.CodeBuilder
> java.lang.classfile.CodeBuilder.instanceOf(java.lang.constant.ClassDesc)'
>
> Javadoc says:
>
> default *CodeBuilder*
> <https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/CodeBuilder.html>
> *PREVIEW*
> <https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/CodeBuilder.html#preview-java.lang.classfile.CodeBuilder>
>
> *instanceOf*
> <https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/classfile/CodeBuilder.html#instanceOf(java.lang.constant.ClassDesc)>
> (*ClassDesc*
> <https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/constant/ClassDesc.html>
>  target)
>
> Generate an instruction to determine if an object is of the given type
>
>
>
> - ?ystein Myhre Andersen
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/classfile-api-dev/attachments/20240917/5cff8d99/attachment-0001.htm>