<div dir="ltr"><div>If you are exciting the tests of this repo (you'd need to use my "monad" branch to do so, but the error is not related to it), then OpenJDK would, for FrameWithMissingType - where the "Missing" class is not present - compute the following bytecode if it the instructions of "m" are copied to a new class:<br></div><div><br> public m(Z)V<br> ILOAD 1<br> IFEQ 1<br> NEW codes/rafael/asmjdkbridge/sample/FrameWithMissingType$Present<br> DUP<br> INVOKESPECIAL codes/rafael/asmjdkbridge/sample/FrameWithMissingType$Present.<init> ()V<br> ASTORE 2</div><div> GOTO 2<br><div></div><div> LABEL 1</div> FRAME SAME<br> NEW codes/rafael/asmjdkbridge/sample/FrameWithMissingType$Missing<br> DUP<br> INVOKESPECIAL codes/rafael/asmjdkbridge/sample/FrameWithMissingType$Missing.<init> ()V<br> ASTORE 2</div><div> LABEL 2<br></div><div> FRAME APPEND [java/lang/Object] // this will render slot 2 of type object, the next two lines yield the verification error<br> ALOAD 2<br> INVOKEINTERFACE codes/rafael/asmjdkbridge/sample/FrameWithMissingType$Iface.m ()V (itf)<br> RETURN</div><div><br></div><div>When specifying the frames explicitly in ASM, this does not happen where the append frame with comment above is correctly:</div><div><br></div><div> FRAME APPEND [codes/rafael/asmjdkbridge/sample/FrameWithMissingType$Iface]</div><div><br></div><div>By "frame weaving" I mean a technique that Byte Buddy is using to take frames of two classes (the user and the "advice" class) and to merge the frame information of both classes on the fly. Other than AspectJ and similar tools, Byte Buddy uses this to compute frames where this merger contains enough information to always yield correct frames without any traversals. Also, these frames can be weaved rather efficiently and it has made Byte Buddy a very popular tool for Java agents. This is also the main reason why I am arguing for a way to explicitly generate stack map tables, as this technique has proven to be so useful.<br></div><div> <br></div><div>As for your second point: I agree that there needs to be some context of what the initial frame is. I just would find it strange to specify it explicitly in an API for writing stack map frames, as this initial frame is implicit and not stored in the class file. I would also argue that there are many use cases for specifying reduced frames. Especially the "same" and "same1" frames are very popular in code generation frameworks: if you wanted to add code somewhere within a method, without writing local variables, but with some if/else logic, you can simply add a same-frame and not care about the greater context of the method. Similarly, append/crop frames are commonly used by modular byte code generators where every module only gets a "free" offset as their input and writes local variables after it via append-frames but crops those changes before handing over to the next module. I would therefore hope that a frame generation API allows to specify frames of any type explicitly. Of course, OpenJDK could do optimization in the background, ASM supports this too, on demand. ASM also has an option to "expand" frames and to only specify full frames, but I would not know that it is used very often, as most code generation tools work on a level where they already have to retain metainformation of some sort that makes emitting efficient frames rather easy. As far as I know, the expanded frame/frame computation modes are mainly used for prototyping. To me, this is another hint that there is demand for explicit frame generation also beyond offering full frames.</div><div><br></div><div>Would you be open to a builder API like the one I suggested? If one would want to use it for only full frames, this would already be supported by only specifying them along the way. If you are open to it, I still offer to create a prototype!</div><div><br></div><div>Thanks, Rafael<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Am Mi., 13. Juli 2022 um 15:17 Uhr schrieb Adam Sotona <<a href="mailto:adam.sotona@oracle.com">adam.sotona@oracle.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div style="overflow-wrap: break-word;" lang="en-CZ">
<div class="gmail-m_-5616181566762798396WordSection1">
<p class="MsoNormal"><span style="font-size:11pt" lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt" lang="EN-US"><u></u> <u></u></span></p>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt">On 13.07.2022 13:49, "Rafael Winterhalter" <<a href="mailto:rafael.wth@gmail.com" target="_blank">rafael.wth@gmail.com</a>> wrote:<u></u><u></u></span></p>
</div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt"><u></u> <u></u></span></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt">ASM offers to override a method in ClassWriter to compute frames without loading classes. Byte Buddy does so, and it is possible to generate stack map frames this way. But it is
still quite an overhead and just as with OpenJDK right now, it does not work when types are missing what is unfortunately rather common, for example if Spring is involved. In contrast, Byte Buddy's frame weaving is always single-pass and does not require any
allocation (per frame), and works with missing types. (Currently, OpenJDK produces a verification error
<a href="https://urldefense.com/v3/__https:/github.com/raphw/asm-jdk-bridge/blob/writer-poc/src/test/java/codes/rafael/asmjdkbridge/sample/FrameWithMissingType.java__;!!ACWV5N9M2RV99hQ!P7dgFjGSUa8LRpucquOmAlRGEEtLaI1HT7magyDRppDtnF_JI6VY4NOKjQ17zq3TH-dib0AbJPVElA5JA6Bv$" target="_blank">
https://github.com/raphw/asm-jdk-bridge/blob/writer-poc/src/test/java/codes/rafael/asmjdkbridge/sample/FrameWithMissingType.java</a>). This is why I would prefer to plug this logic into OpenJDK's class writer, if possible. Of course, this logic is based on
some assumptions, but if you are not trying to cover the general case, one can always be more efficient than a generic processor, just for that it would be a helpful addition.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Could you be, please, more specific about “</span><span style="font-size:11pt">OpenJDK produces a verification error”</span><span style="font-size:11pt">. I don’t see any code using Classfile API in your
sample.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Classfile API is passing unchanged stack maps of unchanged methods through transformations (in default shared constant pool mode).
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">What I agree with is API extension to allow manually pass stack maps also through builder. However
</span><span style="font-size:11pt">I’m not sure what else do you mean by “</span><span style="font-size:11pt">frame weaving”.</span><span style="font-size:11pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt">As for the generator API: The current StackMapFrame objects contain information that is not present in the class file. For example, the attribute offers an "initialFrame", and the
frames themselves contain effective stack and effective locals. For crop frames, those currently contain the types of the cropped frames. For a writer API, OpenJDK's API would hopefully only consume the data as it is written to the class file. That would be
(a) the type of frame and (b) the declared values for stack and locals, or the amount of cropped frames. Of course, one could link all frames within a
</span><span style="font-size:11pt" lang="EN-US">StackMapTableAttribute together and compute this information on the fly. For example by providing some builder:</span><span style="font-size:11pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt" lang="EN-US">StackMapFrameAttribute b = StackMapFrameAttribute.builder(MethodDesc)</span><span style="font-size:11pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt" lang="EN-US"> .append(...)</span><span style="font-size:11pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt" lang="EN-US"> .crop(...)</span><span style="font-size:11pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt" lang="EN-US"> .same(...)</span><span style="font-size:11pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt" lang="EN-US"> .same1(...)</span><span style="font-size:11pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt" lang="EN-US"> .full(...)</span><span style="font-size:11pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt" lang="EN-US"> .build();</span><span style="font-size:11pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt">One could then add this attribute or fail the CodeBuilder if "manual mode" was set without the attribute being present. I think this later option would be a decent API. If you would
consider it, I can offer to prototype such a solution.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">What you are asking for is compressed form of stack map table. Initial stack map frame is a key information for anyone working with stack maps. Having only relative offsets and differentially compressed subsequent
frames is useless information without the initial frame. According to my experience only effective full stack map frames can be transformed or any other way processed. Information about compressed form of every frame is just a secondary. Every stack map table
can be compressed into many equivalent forms.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">I agree with an option for user to specificy labeled full stack map frames.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">However frames compression is something user should not be responsible of, it is similar as to request of manual deflation when writing a zip file. <u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt">Adam<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt">Best regards, Rafael<u></u><u></u></span></p>
</div>
<div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt"><u></u> <u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt"><u></u> <u></u></span></p>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt"><u></u> <u></u></span></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:36pt"><span style="font-size:11pt">Am Di., 12. Juli 2022 um 14:20 Uhr schrieb Adam Sotona <<a href="mailto:adam.sotona@oracle.com" target="_blank">adam.sotona@oracle.com</a>>:<u></u><u></u></span></p>
</div>
<blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal" style="margin-left:36pt">
<span style="font-size:11pt"> <u></u><u></u></span></p>
<p class="MsoNormal" style="margin-left:36pt">
<span style="font-size:11pt"> <u></u><u></u></span></p>
<div style="border-style:solid none none;border-width:1pt medium medium;padding:3pt 0cm 0cm;border-color:currentcolor">
<p class="MsoNormal" style="margin-bottom:12pt;margin-left:36pt">
<b><span style="font-size:12pt;color:black">From: </span></b><span style="font-size:12pt;color:black">classfile-api-dev <<a href="mailto:classfile-api-dev-retn@openjdk.org" target="_blank">classfile-api-dev-retn@openjdk.org</a>> on behalf of Brian Goetz
<<a href="mailto:brian.goetz@oracle.com" target="_blank">brian.goetz@oracle.com</a>><br>
<b>Date: </b>Sunday, 10 July 2022 19:40<br>
<b>To: </b>Rafael Winterhalter <<a href="mailto:rafael.wth@gmail.com" target="_blank">rafael.wth@gmail.com</a>><br>
<b>Cc: </b><a href="mailto:classfile-api-dev@openjdk.org" target="_blank">classfile-api-dev@openjdk.org</a> <<a href="mailto:classfile-api-dev@openjdk.org" target="_blank">classfile-api-dev@openjdk.org</a>><br>
<b>Subject: </b>Re: POC: JDK ClassModel -> ASM ClassReader</span><span style="font-size:11pt"><u></u><u></u></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12pt;margin-left:72pt">
<span style="font-size:11pt"><br>
<br>
> StackMapFrames could on the other hand just be added at their position in the CodeElement iteration to receive them where they become relevant. This way, one would not need to keep track of the current offset. This would also allow for an easier write model
where ASM does not allow you to know the offset of a stack map. I assume that the current model is very much modeled after the needs of the javap tool. Ideally, the frame objects would be reduced to the information that is contained in a class file and the
consumer could track implicit information such as the "effective" stack and locals.<br>
<br>
There are two concerns with this, one minor and one major. The minor one is that this has a significant cost, and most users don’t want this information. So we would surely want to gate this with an option whose default is false. (We care the most about
transformation, and most transformations make only light changes, so we don’t want to add costs that most users won’t want to bear.).
<br>
<br>
The major one is how it perturbs the model. The element stream delivered by a model, and the one consumed by a builder, should be duals. What should a builder do when handed a frame? Switch responsibility over to the user for correct frame generation? Ignore
it and regenerate stack maps anyway? <br>
<br>
I think we need a better picture of “who is the audience for this sub feature” before designing the API.
<u></u><u></u></span></p>
<p class="MsoNormal" style="margin-bottom:12pt;margin-left:36pt">
<span style="font-size:11pt" lang="EN-US">I’ve been considering (and re-considering) many various scenarios related to stack maps.</span><span style="font-size:11pt"><u></u><u></u></span></p>
<p class="MsoNormal" style="margin-bottom:12pt;margin-left:36pt">
<span style="font-size:11pt" lang="EN-US">Number one requirement is to generate valid stack maps in any circumstances and with minimal performance penalty. And we already do a lot in this area:</span><span style="font-size:11pt"><u></u><u></u></span></p>
<p class="gmail-m_-5616181566762798396gmail-m7404434680222909313msolistparagraph" style="margin-right:0cm;margin-bottom:12pt;margin-left:72pt">
<u></u><span style="font-size:10pt;font-family:Symbol"><span>·<span style="font:7pt "Times New Roman"">
</span></span></span><u></u><span lang="EN-US">Stack maps generation requires minimal information about involved classes and only to resolve controversial situations (for example when looking for common parent of dual assignment to a single local variable).
Required information is minimal and limited to individual classes (is this specific class an interface or what is its parent class). On the other side for example ASM requires to load the classes with all dependencies to generate stack maps.</span><u></u><u></u></p>
<p class="gmail-m_-5616181566762798396gmail-m7404434680222909313msolistparagraph" style="margin-right:0cm;margin-bottom:12pt;margin-left:72pt">
<u></u><span style="font-size:10pt;font-family:Symbol"><span>·<span style="font:7pt "Times New Roman"">
</span></span></span><u></u><span lang="EN-US">Generation process is fast and does not produce any temporary structures and objects. It is single-pass in >95% cases, dual-pass in >4% cases and maximum three-pass in the remaining ~1% of cases (statistics
calculated from very large corpus of classes).</span><u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:12pt;margin-left:36pt">
<span style="font-size:11pt" lang="EN-US">Experiments to involve transformed original stack maps led to increased complexity, worse performance, and mainly failed to produce valid stack maps. There is no benefit of passing user-created (or somehow transformed)
stack map frames to the generator for final processing.</span><span style="font-size:11pt"><u></u><u></u></span></p>
<p class="MsoNormal" style="margin-bottom:12pt;margin-left:36pt">
<span style="font-size:11pt" lang="EN-US">From the discussion (and from my experience with class instrumentation) I see one use case we didn’t cover and one case where we can improve:</span><span style="font-size:11pt"><u></u><u></u></span></p>
<p class="gmail-m_-5616181566762798396gmail-m7404434680222909313msolistparagraph" style="margin-right:0cm;margin-bottom:12pt;margin-left:72pt">
<u></u><span>1.<span style="font:7pt "Times New Roman"">
</span></span><u></u><span lang="EN-US">We handle well class transformation from single source. Shared constant pool allows to keep original stack maps for all methods with unmodified bytecode. However, class instrumentation is a transformation with at least
two sources. Such transformation can share only one constant pool. All methods from the second source must be exploded to instructions, reconstructed and stack maps generated from scratch. Author of such transformation must be fully aware of the consequences
and having an option to pass stack maps through non-shared CP transformation would be a valuable feature. It would require:</span><u></u><u></u></p>
<p class="gmail-m_-5616181566762798396gmail-m7404434680222909313msolistparagraph" style="margin-right:0cm;margin-bottom:12pt;margin-left:108pt">
<u></u><span>a.<span style="font:7pt "Times New Roman"">
</span></span><u></u><span lang="EN-US">Option to individually turn off stack map generation per method (because there might be also synthetic methods where sm generation is required). I would propose to implement Code-level override of global options.
</span><u></u><u></u></p>
<p class="gmail-m_-5616181566762798396gmail-m7404434680222909313msolistparagraph" style="margin-right:0cm;margin-bottom:12pt;margin-left:108pt">
<u></u><span>b.<span style="font:7pt "Times New Roman"">
</span></span><u></u><span lang="EN-US">Factory for stack map table manual construction (based on labels, not offsets). I would propose to put this “manual mode” aside from CodeBuilder and implement it as StackMapTableAttribute.of(Frame…) factory.</span><u></u><u></u></p>
<p class="gmail-m_-5616181566762798396gmail-m7404434680222909313msolistparagraph" style="margin-right:0cm;margin-bottom:12pt;margin-left:72pt">
<u></u><span>2.<span style="font:7pt "Times New Roman"">
</span></span><u></u><span lang="EN-US">There are cases where required class hierarchy is not available (when there is no access to all jars), so it would be hard for user to provide appropriate ClassHierarchyResolver. However, many individual class information
can be theoretically extracted from the source classes (from class headers, from existing stack maps, from other attributes or from the bytecode itself). It is just an idea; however I think it might be possible to implement an optional hierarchy resolver,
that will learn from the parsed classes. It is a theoretical option for improvement, without throwing that responsibility on user. However, any such solution would remain in category of non-deterministic. Altering a stack map without minimal knowledge of the
involved classes is still a blind surgery.</span><u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:12pt;margin-left:72pt">
<span style="font-size:11pt"> <u></u><u></u></span></p>
<p class="MsoNormal" style="margin-bottom:12pt;margin-left:36pt">
<span style="font-size:11pt" lang="EN-US">Thanks,</span><span style="font-size:11pt"><u></u><u></u></span></p>
<p class="MsoNormal" style="margin-bottom:12pt;margin-left:36pt">
<span style="font-size:11pt" lang="EN-US">Adam</span><span style="font-size:11pt"><u></u><u></u></span></p>
<p class="MsoNormal" style="margin-bottom:12pt;margin-left:72pt">
<span style="font-size:11pt"><u></u> <u></u></span></p>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote></div>