<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<font size="4"><font face="monospace">That's a good move. Can we
push further? We have types here for mapping a key to a:<br>
<br>
- list of simple values<br>
- list of arbitrary fragments <br>
- list of printables<br>
- list of list of printable (blocklist)<br>
<br>
<br>
</font></font><br>
<div class="moz-cite-prefix">On 7/25/2022 1:20 PM, Adam Sotona
wrote:<br>
</div>
<blockquote type="cite" cite="mid:CY4PR1001MB21506E7A0F396BDE473248468C959@CY4PR1001MB2150.namprd10.prod.outlook.com">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}@font-face
{font-family:"Apple Color Emoji";
panose-1:0 0 0 0 0 0 0 0 0 0;}@font-face
{font-family:"Courier New \;color\:\#336BDD";
panose-1:2 7 3 9 2 2 5 2 4 4;}@font-face
{font-family:"Courier New \;color\:\#CE54B8";
panose-1:2 7 3 9 2 2 5 2 4 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}div.WordSection1
{page:WordSection1;}</style>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US">Or
maybe we could let the printer to auto-quote as needed by
the actual value in the context of the actual format
</span><span style="font-size:11.0pt;font-family:"Apple
Color Emoji"" lang="EN-US">😊</span><span style="font-size:11.0pt" lang="EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US">So
yes, it can be reduced:<o:p></o:p></span></p>
<pre style="margin-left:72.0pt;background:white"><span style="color:#336BDD">public</span><span style="color:black"> </span><span style="color:#336BDD">sealed</span><span style="color:black"> </span><span style="color:#336BDD">interface</span><span style="color:black"> <b>Printable</b> {</span></pre>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span><span style="font-family:"Courier New";color:black">
String
<b>key</b>();</span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">sealed</span><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">interface</span><span style="font-family:"Courier New";color:black">
<b><i>Fragment</i></b> </span><span style="font-family:"Courier New";color:#336BDD">extends</span><span style="font-family:"Courier New";color:black">
Printable {}</span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">record</span><span style="font-family:"Courier New";color:black">
<i>Value</i>(String </span><span style="font-family:"Courier New";color:#CE54B8">key</span><span style="font-family:"Courier New";color:black">,
<s>String</s> ConstantDesc </span><span style="font-family:"Courier New
\;color\:\#CE54B8";color:black">value</span><span style="font-family:"Courier New";color:black">)
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">implements</span><span style="font-family:"Courier New";color:black">
<i>Fragment</i> {}</span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><s><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span></s><s><span style="font-family:"Courier New";color:black">
</span></s><s><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">record</span></s><s><span style="font-family:"Courier New";color:black">
<i>Quoted</i>(String </span></s><s><span style="font-family:"Courier New";color:#CE54B8">key</span></s><s><span style="font-family:"Courier New";color:black">,
String
</span></s><s><span style="font-family:"Courier New
\;color\:\#CE54B8";color:black">value</span></s><s><span style="font-family:"Courier New";color:black">)
</span></s><s><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">implements</span></s><s><span style="font-family:"Courier New";color:black">
<i>Fragment</i> {}</span><o:p></o:p></s></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><s><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span></s><s><span style="font-family:"Courier New";color:black">
</span></s><s><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">record</span></s><s><span style="font-family:"Courier New";color:black">
<i>Decimal</i>(String </span></s><s><span style="font-family:"Courier New";color:#CE54B8">key</span></s><s><span style="font-family:"Courier New";color:black">,
</span></s><s><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">int</span></s><s><span style="font-family:"Courier New";color:black">
</span></s><s><span style="font-family:"Courier New
\;color\:\#CE54B8";color:black">value</span></s><s><span style="font-family:"Courier New";color:black">)
</span></s><s><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">implements</span></s><s><span style="font-family:"Courier New";color:black">
<i>Fragment</i> {}</span><o:p></o:p></s></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">record</span><span style="font-family:"Courier New";color:black">
<i>ValueList</i>(String </span><span style="font-family:"Courier New";color:#CE54B8">key</span><span style="font-family:"Courier New";color:black">,
List<<s>String</s></span><span style="color:black">
</span><span style="font-family:"Courier
New";color:black">ConstantDesc> </span><span style="font-family:"Courier New
\;color\:\#CE54B8";color:black">values</span><span style="font-family:"Courier New";color:black">)
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">implements</span><span style="font-family:"Courier New";color:black">
<i>Fragment</i> {}</span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><s><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span></s><s><span style="font-family:"Courier New";color:black">
</span></s><s><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">record</span></s><s><span style="font-family:"Courier New";color:black">
<i>QuotedList</i>(String </span></s><s><span style="font-family:"Courier New";color:#CE54B8">key</span></s><s><span style="font-family:"Courier New";color:black">,
List<String>
</span></s><s><span style="font-family:"Courier New
\;color\:\#CE54B8";color:black">values</span></s><s><span style="font-family:"Courier New";color:black">)
</span></s><s><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">implements</span></s><s><span style="font-family:"Courier New";color:black">
<i>Fragment</i> {}</span><o:p></o:p></s></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">record</span><span style="font-family:"Courier New";color:black">
<i>Mapping</i>(String </span><span style="font-family:"Courier New";color:#CE54B8">key</span><span style="font-family:"Courier New";color:black">,
List<<i>Fragment</i>>
</span><span style="font-family:"Courier New
\;color\:\#CE54B8";color:black">fragments</span><span style="font-family:"Courier New";color:black">)
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">implements</span><span style="font-family:"Courier New";color:black">
Printable {}</span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">record</span><span style="font-family:"Courier New";color:black">
<i>BlockMapping</i>(String </span><span style="font-family:"Courier New";color:#CE54B8">key</span><span style="font-family:"Courier New";color:black">,
List<Printable>
</span><span style="font-family:"Courier New
\;color\:\#CE54B8";color:black">printables</span><span style="font-family:"Courier New";color:black">)
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">implements</span><span style="font-family:"Courier New";color:black">
Printable {}</span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">record</span><span style="font-family:"Courier New";color:black">
<i>BlockList</i>(String </span><span style="font-family:"Courier New";color:#CE54B8">key</span><span style="font-family:"Courier New";color:black">,
List<<i>BlockMapping</i>>
</span><span style="font-family:"Courier New
\;color\:\#CE54B8";color:black">blockMappings</span><span style="font-family:"Courier New";color:black">)
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">implements</span><span style="font-family:"Courier New";color:black">
Printable {}</span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt;background:white"><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">public</span><span style="font-family:"Courier New";color:black">
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">record</span><span style="font-family:"Courier New";color:black">
<i>Comment</i>(String </span><span style="font-family:"Courier New";color:#CE54B8">key</span><span style="font-family:"Courier New";color:black">)
</span><span style="font-family:"Courier New
\;color\:\#336BDD";color:black">implements</span><span style="font-family:"Courier New";color:black">
Printable {}</span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal" style="margin-left:36.0pt"><span style="font-size:11.0pt">On 25.07.2022 19:03,
"classfile-api-dev"
<a class="moz-txt-link-rfc2396E" href="mailto:classfile-api-dev-retn@openjdk.org"><classfile-api-dev-retn@openjdk.org></a> wrote:<o:p></o:p></span></p>
</div>
<p class="MsoNormal" style="margin-left:36.0pt"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span style="font-size:11.0pt" lang="EN-US">Unfortunately it is
format-specific.</span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span style="font-size:11.0pt" lang="EN-US">We can unify it down
to “all-quoted” however the visual benefits will be lost.</span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span style="font-size:11.0pt" lang="EN-US"> </span></p>
<p class="MsoNormal" style="margin-left:36.0pt"><span style="font-size:11.0pt" lang="EN-US"> </span></p>
<div>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt">On 25.07.2022 19:00, "Brian
Goetz" <a class="moz-txt-link-rfc2396E" href="mailto:brian.goetz@oracle.com"><brian.goetz@oracle.com></a> wrote:</span></p>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:0cm;margin-right:0cm;margin-bottom:12.0pt;margin-left:72.0pt"><span style="font-size:11.0pt"><br>
</span><span style="font-size:13.5pt;font-family:"Courier
New"">This seems like nice progress. I wonder if we
can boil it down further? Can we, for example, get rid of
Quoted by Plain(key, "\"value\""), and such?
<br>
<br>
<br>
</span></p>
<div>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt">On 7/25/2022 12:40 PM, Adam
Sotona wrote:</span></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US">During the
experiments I found generic map-of-maps is too loose and
missing any formatting information.
</span></p>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US">The API below has
been derived from the requirements of the actual
ClassPrinter and made as a minimal set of formatting
features unified for producing JSON, YAML and XML.</span></p>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US">The API also tries
to avoid problematic combinations (for example list of
lists is not possible, but list of maps of lists works
perfectly).</span></p>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US">Each Classfile API
model can provide its printable form in the future.</span></p>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US">Printers
implementations are generic and very simple (~80 lines of
code each, mainly one big switch expression) and custom
printers can be implemented.
</span></p>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US">Please let me know
your comments before I start rewriting the ClassPrinter
into this intermediate form.</span></p>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US"> </span></p>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US">Thanks,</span></p>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US">Adam</span></p>
<p class="MsoNormal" style="margin-left:72.0pt"><span style="font-size:11.0pt" lang="EN-US"> </span></p>
<p class="MsoNormal" style="mso-margin-top-alt:0cm;margin-right:36.0pt;margin-bottom:0cm;margin-left:108.0pt;margin-bottom:.0001pt"><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal" style="margin-left:72.0pt"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>