<div dir="ltr">I've updated the PR to include the following:<div>* CE.adding/addingSymbols methods</div><div>* a List<CE> deduplicate(List<CE>) method that removes duplicate entries from the List</div><div>* equals() methods to the ConcreteEntry subclasses</div><div><br></div><div>Let me know if this fits with the intended approach for the jdk.classfile library.</div><div><br></div><div><a href="https://github.com/openjdk/jdk-sandbox/pull/35">https://github.com/openjdk/jdk-sandbox/pull/35</a><br></div><div><br></div><div>--Dan</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Aug 24, 2022 at 2:55 PM Brian Goetz <<a href="mailto:brian.goetz@oracle.com">brian.goetz@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<font size="4"><font face="monospace">I'd say let's give this a try
and see what we think of the resulting transformation code. It
feels like right-sizing the overhead at first look.</font></font><br>
<br>
<div>On 8/24/2022 9:22 AM, Dan Heidinga
wrote:<br>
</div>
<blockquote type="cite">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
</blockquote>
<div><br>
</div>
<div>I took another pass through the Attributes that deal with
Lists of things and most cases are well handled by existing List
helpers. It's only the CE/CD cases that need data conversion
and would therefore benefit from additional methods to create
their lists.<br>
</div>
<div><br>
</div>
<div>If we expect to be content with these 4 methods, then adding
them as static methods on ClassEntry seems reasonable. It makes
them easy to find and avoids a garbage "Helpers/Utils" class.
If we expect more of these methods (and I currently don't but
that may be lack of imagination), then a garbage class might be
better.</div>
</blockquote>
<br>
</div>
</blockquote></div>