<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Menlo;
panose-1:2 11 6 9 3 8 4 2 2 4;}
@font-face
{font-family:"Segoe UI";
panose-1:2 11 5 2 4 2 4 2 2 3;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
code
{mso-style-priority:99;
font-family:"Courier New";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:634675981;
mso-list-template-ids:1204309646;}
@list l1
{mso-list-id:1569074232;
mso-list-type:hybrid;
mso-list-template-ids:941265944 134807567 134807577 134807579 134807567 134807577 134807579 134807567 134807577 134807579;}
@list l1:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:38.25pt;
text-indent:-18.0pt;}
@list l1:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:74.25pt;
text-indent:-18.0pt;}
@list l1:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
margin-left:110.25pt;
text-indent:-9.0pt;}
@list l1:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:146.25pt;
text-indent:-18.0pt;}
@list l1:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:182.25pt;
text-indent:-18.0pt;}
@list l1:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
margin-left:218.25pt;
text-indent:-9.0pt;}
@list l1:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:254.25pt;
text-indent:-18.0pt;}
@list l1:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:290.25pt;
text-indent:-18.0pt;}
@list l1:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
margin-left:326.25pt;
text-indent:-9.0pt;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style>
</head>
<body lang="en-CZ" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">5. Classfile API CodeBuilder::transforming clarification<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">classfile-api-dev <classfile-api-dev-retn@openjdk.org> on behalf of Adam Sotona <adam.sotona@oracle.com><br>
<b>Date: </b>Tuesday, 7 March 2023 15:40<br>
<b>To: </b>classfile-api-dev@openjdk.org <classfile-api-dev@openjdk.org><br>
<b>Subject: </b>Classfile API tracking RFEs<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Hi,</span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Some of the proposed RFEs fall beyond the initial Classfile API pull request and we should probably start filling them to JBS or find another way to track them.</span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US"> </span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Here are listed citations (for temporary tracking purpose) what I’ve collected from the feedback:</span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US"> </span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<ol style="margin-top:0cm" start="1" type="1">
<li class="MsoListParagraph" style="margin-left:2.25pt;mso-list:l1 level1 lfo3"><code><span style="font-size:9.0pt;font-family:Menlo;color:#24292F;mso-fareast-language:EN-US">switch</span></code><span class="apple-converted-space"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#24292F;background:white;mso-fareast-language:EN-US"> </span></span><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#24292F;background:white;mso-fareast-language:EN-US">seems
the one instruction for which an high-level variant (like<span class="apple-converted-space"> </span></span><code><span style="font-size:9.0pt;font-family:Menlo;color:#24292F;mso-fareast-language:EN-US">trying</span></code><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#24292F;background:white;mso-fareast-language:EN-US">)
could be useful, as generating code for that can be quite painful.</span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></li><li class="MsoListParagraph" style="margin-left:2.25pt;mso-list:l1 level1 lfo3"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#24292F;background:white;mso-fareast-language:EN-US">I noticed that this pattern of start/endScope is here,
but also in ExceptionCatch, LocalVariable and LocalVariableType. Consider using a common interface for "instructions that are associated with a range".</span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></li><li class="MsoListParagraph" style="margin-left:2.25pt;mso-list:l1 level1 lfo3"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#24292F;background:white;mso-fareast-language:EN-US">Should we add a helper method on<span class="apple-converted-space"> </span></span><code><span style="font-size:9.0pt;font-family:Menlo;color:#24292F;mso-fareast-language:EN-US">CodeBuilder</span></code><span class="apple-converted-space"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#24292F;background:white;mso-fareast-language:EN-US"> </span></span><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:#24292F;background:white;mso-fareast-language:EN-US">that
does the new + dup + invoke special dance?</span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></li><li class="MsoListParagraph" style="margin-left:2.25pt;mso-list:l1 level1 lfo3"><span class="apple-converted-space"><span style="font-size:11.0pt;color:#212121;mso-fareast-language:EN-US"> </span></span><span style="font-size:11.0pt;color:#212121;mso-fareast-language:EN-US">Another
issue with the model is ClassTypeSig does not validate its input</span><span lang="EN-US" style="font-size:11.0pt;color:#212121;mso-fareast-language:EN-US">.</span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></li></ol>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US"> </span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Thanks,</span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Adam</span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></p>
</div>
</body>
</html>