<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 31/03/2023 15:51, Brian Goetz wrote:<br>
</div>
<blockquote type="cite" cite="mid:685ebed0-1d2b-2d42-cc5f-7607e71f228a@oracle.com">
<font size="4"><font face="monospace">Yes, really this is
shorthand for allocating a local _slot_. And this really is
allocation -- its a slab allocator with stack-based
allocation/deallocation of sub-slabs. <br>
</font></font></blockquote>
<font size="4"><font face="monospace">Not sure I follow what you
mean here. All the implementations of this methods just bump an
index and return (which is what I'd expect)... am I missing
something in the impl?</font></font><br>
<blockquote type="cite" cite="mid:685ebed0-1d2b-2d42-cc5f-7607e71f228a@oracle.com"><font size="4"><font face="monospace"> <br>
Names like "newLocal" don't really capture what's going on,
because we're not, for example, making a data structure that
represents a local, we're reserving a slot for it. <br>
<br>
I had considered "allocateSlot" which is more accurate but I
thought "slot" by itself might be obvious. Other options
include:<br>
<br>
allocateLocalSlot<br>
reserveLocal<br>
reserveLocalSlot<br>
more?<br>
</font></font></blockquote>
<p><font size="4"><font face="monospace">I guess the "reserve" is a
good one, at least subjectively.</font></font></p>
<p><font size="4"><font face="monospace">Maurizio<br>
</font></font></p>
<blockquote type="cite" cite="mid:685ebed0-1d2b-2d42-cc5f-7607e71f228a@oracle.com"><font size="4"><font face="monospace"> </font></font><br>
<div class="moz-cite-prefix">On 3/31/2023 7:54 AM, Maurizio
Cimadamore wrote:<br>
</div>
<blockquote type="cite" cite="mid:6c9e4dae-6403-9d00-c91b-ce7b00eff6f3@oracle.com">Hi, <br>
while reviewing this: <br>
<br>
<a class="moz-txt-link-freetext" href="https://git.openjdk.org/jdk/pull/13247" moz-do-not-send="true">https://git.openjdk.org/jdk/pull/13247</a>
<br>
<br>
I couldn't help but getting rubbed the wrong way seeing
"allocate" next to "Local". I realize this might be a subjective
bias (I've been staring at memory allocators for too long :-) ),
but I don't think that the concept of "allocation" belongs to
local variables? I think a more neutral "newLocal", "makeLocal",
"createLocal" might work better in this regard. <br>
<br>
Cheers <br>
Maurizio <br>
<br>
</blockquote>
<br>
</blockquote>
</body>
</html>