<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:12.0pt;
font-family:"Aptos",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Aptos",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<div id="mail-editor-reference-message-container">
<div>
<div>
<p class="MsoNormal">Please review following PR and related <a href="https://bugs.openjdk.org/browse/JDK-8329501">
CSR</a>.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thank you!<o:p></o:p></p>
<p class="MsoNormal">Adam<o:p></o:p></p>
<p class="MsoNormal"><b><o:p> </o:p></b></p>
<p class="MsoNormal"><b><o:p> </o:p></b></p>
<p class="MsoNormal" style="margin-left:.5in"><span style="font-size:11.0pt">`IllegalArgumentException` thrown by some static factory methods of the following `java.lang.classfile.instruction` interfaces are not documented:<br>
<br>
- `ArrayLoadInstruction`<br>
- `ArrayStoreInstruction`<br>
- `BranchInstruction`<br>
- `ConvertInstruction`<br>
- `DiscontinuedInstruction`<br>
- `FieldInstruction`<br>
- `InvokeInstruction`<br>
- `LoadInstruction`<br>
- `MonitorInstruction`<br>
- `NewPrimitiveArrayInstruction`<br>
- `OperatorInstruction`<br>
- `ReturnInstruction`<br>
- `StackInstruction`<br>
- `StoreInstruction`<br>
- `TypeCheckInstruction`<br>
<br>
`NewPrimitiveArrayInstruction::of` factory method also does not perform the check for invalid argument.<br>
<br>
This patch adds all the missing `@throws` Javadoc tags and fixes `NewPrimitiveArrayInstruction::of` factory method to perform the argument check.<br>
<br>
Please review.<br>
<br>
Thank you,<br>
Adam<br>
<br>
-------------<br>
<br>
Commit messages:<br>
- 8329099: Undocumented exception thrown by Instruction factory methods accepting Opcode<br>
<br>
Changes: <a href="https://git.openjdk.org/jdk/pull/18578/files">https://git.openjdk.org/jdk/pull/18578/files</a><br>
Webrev: <a href="https://webrevs.openjdk.org/?repo=jdk&pr=18578&range=00">https://webrevs.openjdk.org/?repo=jdk&pr=18578&range=00</a><br>
Issue: <a href="https://bugs.openjdk.org/browse/JDK-8329099">https://bugs.openjdk.org/browse/JDK-8329099</a><br>
Stats: 36 lines in 15 files changed: 36 ins; 0 del; 0 mod<br>
Patch: <a href="https://git.openjdk.org/jdk/pull/18578.diff">https://git.openjdk.org/jdk/pull/18578.diff</a><br>
Fetch: git fetch <a href="https://git.openjdk.org/jdk.git">https://git.openjdk.org/jdk.git</a> pull/18578/head:pull/18578<br>
<br>
PR: <a href="https://git.openjdk.org/jdk/pull/18578">https://git.openjdk.org/jdk/pull/18578</a><o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>